DBAPI based on Query Service #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvoleg
force-pushed
the
new_dbapi
branch
2 times, most recently
from
63c0263 to
baabab8
Compare
LuckySting
suggested changes
Oct 22, 2024
vgvoleg
force-pushed
the
new_dbapi
branch
3 times, most recently
from
8117b8e to
be55108
Compare
LuckySting
suggested changes
Oct 29, 2024
| return self._tx_context.execute( | ||
| query=query, | ||
| parameters=parameters, | ||
| commit_tx=self._autocommit, |
There was a problem hiding this comment.
question: I think if tx_context is None we could do it, so autocommit variable could be removed
There was a problem hiding this comment.
tx_context is None only in case of AUTOCOMMIT isolation level, but we have other levels with interactive transactions ON/OFF.
| def _execute_generic_query( | ||
| self, query: str, parameters: ParametersType | None = None | ||
| ) -> Iterator[ydb.convert.ResultSet]: | ||
| return self._session.execute(query=query, parameters=parameters) |
There was a problem hiding this comment.
question: Why you don't use session_pool.retry_operation?
There was a problem hiding this comment.
I will do it out of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.