Skip to content

add fan @horw #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2025
Merged

add fan @horw #146

merged 3 commits into from
Jan 5, 2025

Conversation

horw
Copy link
Contributor

@horw horw commented Dec 26, 2024

Hello! I’ve added my nickname to this list.
Also, as @gennadygennady pointed out, the indentation, order and ',' are incorrect in this list.
If you're interested, I’ve written a formatter script for these sections that will help maintain format in the future.

@yegor256
Copy link
Owner

@horw looks like a perfect contribution to this repository. How about we make this script running on every push, but GitHub Action. Then, after it reformats the README file, it should submit a pull request. See how it works, for example, here: https://github.com/objectionary/eoc/blob/master/.github/workflows/up.yml (the number of the version is updated)

@horw
Copy link
Contributor Author

horw commented Dec 27, 2024

@horw looks like a perfect contribution to this repository. How about we make this script running on every push, but GitHub Action. Then, after it reformats the README file, it should submit a pull request. See how it works, for example, here: https://github.com/objectionary/eoc/blob/master/.github/workflows/up.yml (the number of the version is updated)

Thank you for the answer. I agree, I will add it.

@horw horw force-pushed the docs/horw branch 3 times, most recently from e48a1a6 to d0dd275 Compare December 27, 2024 07:30
@horw
Copy link
Contributor Author

horw commented Dec 27, 2024

@yegor256, I have taken a look at your workflow in the following link, but I don't fully agree with the way it handles this checking process.


There are actually two approaches to workflows:

  • Blocking
  • Non-blocking

Blocking (Executed when a user contributes)

This type of workflow rejects commits from users if they don't align with your contribution guidelines. Users will see the error, and if they want to continue contributing to your repository, they will need to make changes to their PR. This approach acts like a contract: the workflow checks all requirements, and only after they are met does it allow the PR to proceed.
This type of contribution also provides a learning opportunity for users. They receive error notifications and feedback, which helps them become more professional in the future.

Non-blocking (Executed after a user has contributed)

In this type of workflow, you allow anything to be merged. As a result, you need to figure out what has already been added. Some commits might introduce breaking changes or cause scripts to fail, requiring more time to fix issues or even revert changes. Additionally, users may feel free to push 'random' changes, which prevents them from learning anything meaningful.


I understand that this might not directly relate to this repository, but who knows what will happen to it in the future? It's always better to adopt good practices from the start.

@horw horw force-pushed the docs/horw branch 2 times, most recently from e90b982 to 48562b4 Compare December 28, 2024 13:57
@horw
Copy link
Contributor Author

horw commented Dec 28, 2024

Rebased

@horw
Copy link
Contributor Author

horw commented Jan 5, 2025

Hello @yegor256, should we rerun the pipeline again?

@yegor256
Copy link
Owner

yegor256 commented Jan 5, 2025

@horw there are merge conflicts, please merge master into your branch

@horw
Copy link
Contributor Author

horw commented Jan 5, 2025

Thank you, I have rebased, @yegor256

@yegor256 yegor256 merged commit 01c9d56 into yegor256:master Jan 5, 2025
1 check passed
@yegor256
Copy link
Owner

yegor256 commented Jan 5, 2025

@horw thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants