-
Notifications
You must be signed in to change notification settings - Fork 72
add fan @horw #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fan @horw #146
Conversation
@horw looks like a perfect contribution to this repository. How about we make this script running on every push, but GitHub Action. Then, after it reformats the README file, it should submit a pull request. See how it works, for example, here: https://github.com/objectionary/eoc/blob/master/.github/workflows/up.yml (the number of the version is updated) |
Thank you for the answer. I agree, I will add it. |
e48a1a6
to
d0dd275
Compare
@yegor256, I have taken a look at your workflow in the following link, but I don't fully agree with the way it handles this checking process. There are actually two approaches to workflows:
Blocking (Executed when a user contributes)This type of workflow rejects commits from users if they don't align with your contribution guidelines. Users will see the error, and if they want to continue contributing to your repository, they will need to make changes to their PR. This approach acts like a contract: the workflow checks all requirements, and only after they are met does it allow the PR to proceed. Non-blocking (Executed after a user has contributed)In this type of workflow, you allow anything to be merged. As a result, you need to figure out what has already been added. Some commits might introduce breaking changes or cause scripts to fail, requiring more time to fix issues or even revert changes. Additionally, users may feel free to push 'random' changes, which prevents them from learning anything meaningful. I understand that this might not directly relate to this repository, but who knows what will happen to it in the future? It's always better to adopt good practices from the start. |
e90b982
to
48562b4
Compare
Rebased |
Hello @yegor256, should we rerun the pipeline again? |
@horw there are merge conflicts, please merge master into your branch |
Thank you, I have rebased, @yegor256 |
@horw thanks! |
Hello! I’ve added my nickname to this list.
Also, as @gennadygennady pointed out, the indentation, order and ',' are incorrect in this list.
If you're interested, I’ve written a formatter script for these sections that will help maintain format in the future.