AWS Marketplace Configuration #403
Conversation
| on: | ||
| push: | ||
| tags: | ||
| - 'v*.*.*' # Enforce Semantic Versioning |
There was a problem hiding this comment.
have you confirmed what happens if we overwrite a tag? That is something that happens on occasion.
| contents: read # required to checkout the code from the repo | ||
| steps: | ||
| - name: Install JQ | ||
| run: sudo apt update && sudo apt install -y jq |
There was a problem hiding this comment.
im not seeing where this is utilized
There was a problem hiding this comment.
nevermind, i see it in the sh. Is this usually how we install shell deps?
| @@ -0,0 +1,224 @@ | |||
| AWSTemplateFormatVersion: '2010-09-09' | |||
There was a problem hiding this comment.
should i assume this is identical to old vpc? if so do we need the dupe?
There was a problem hiding this comment.
it is identical I just duped for consistency, but duping here isn't necessary.
| @@ -0,0 +1,161 @@ | |||
| AWSTemplateFormatVersion: "2010-09-09" | |||
There was a problem hiding this comment.
is this whole template just an abstract password generator for use in other templates? It seems like it asks for a path(s), and then CREATES the passwords in SSM? Just kind of skips anyone having to actually go in there i guess...
| @@ -0,0 +1,39 @@ | |||
| AWSTemplateFormatVersion: '2010-09-09' | |||
There was a problem hiding this comment.
so im guessing this one and the next one are more for US not for the actual client deployment?
| Description: Version of SQL LRS to pull from Mapping of AMIs | ||
| Type: String | ||
| AllowedValues: | ||
| - v0713 |
There was a problem hiding this comment.
woof, this is the best they can do with semver? I can see this being an issue down the line...
There was a problem hiding this comment.
well the results of the amibuilder are just ami IDs, what im doing here is mapping from semver->region->ami ID. Unfortunately this does mean this template requires manual updates of those mappings for every release.
| !Join [":", [!Ref "SecretStackName", "DBMasterUsername"]] | ||
| MasterPasswordPath: | ||
| Fn::ImportValue: | ||
| !Join [":", [!Ref "SecretStackName", "DBMasterUserPasswordPath"]] |
| Resource: "*" | ||
|
|
||
| IngressRuleLambda: | ||
| Type: AWS::Lambda::Function |
There was a problem hiding this comment.
I am unclear on the role of this fn
This adds a separate marketplace cloud formation configuration for LRSQL (with plans to eventually make this the default configuration for LRSQL deploys marketplace or not).