Skip to content

Check for minimum required Windows version #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2025
Merged

Check for minimum required Windows version #2192

merged 1 commit into from
Aug 2, 2025

Conversation

thbeu
Copy link
Contributor

@thbeu thbeu commented Jul 31, 2025

Resolves #2191.

@yhirose
Copy link
Owner

yhirose commented Jul 31, 2025

@sum01 @jimmy-park could you please review this pull request for me? Thanks!

@sum01
Copy link
Contributor

sum01 commented Aug 1, 2025

My first thought is to use CMAKE_SYSTEM_VERSION instead.

With CMAKE_HOST_SYSTEM_VERSION if you cross-compile it could fail if the build system version returns < 10, regardless of if you're on Windows or not.

Maybe you have other thoughts though?

@thbeu thbeu force-pushed the issue_2191_cmake branch from 2146f71 to 30efed1 Compare August 1, 2025 16:07
@thbeu
Copy link
Contributor Author

thbeu commented Aug 1, 2025

My first thought is to use CMAKE_SYSTEM_VERSION instead.

Sure. I changed it accordingly.

@yhirose yhirose merged commit acf28a3 into yhirose:master Aug 2, 2025
10 checks passed
@yhirose
Copy link
Owner

yhirose commented Aug 2, 2025 •
edited
Loading

Thanks for making the improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for minimum required Win version
3 participants
@thbeu @yhirose @sum01