Fix codemirror.css stylesheet address
#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project `codemirror` v5 changed all the urls adding `5` infix. So the live demo shows nothing now because styles are not loaded. I consider this fix as a workaround through, because I believe it is recommended to use local copy of `codemirror.css` or use third-party repositories. Another opportunity is to link directly so some github commit of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project
codemirrorv5 changed all the urls adding5infix. So the live demo shows nothing now because styles are not loaded. I consider this fix as a workaround through, because I believe it is recommended to use local copy ofcodemirror.cssor use third-party repositories. Another opportunity is to link directly so some github commit of the file.