only set localisation if it's different than inherited localisation. this is important for front end performance as it reduces the number of iterations when getting the variant for the requested path

Author: yohsii

core/Controllers/ApiController.cs

@@ -520,19 +520,6 @@ public JsonResult Localisation(string p_path)
             var model = apiHelper.PathLocalisation(p_path);
             return Json(model);
         }
-        [Authorize(Roles = PuckRoles.Puck, AuthenticationSchemes = Mvc.AuthenticationScheme)]
-        public JsonResult RootsLocalisations(string ids)
-        {
-            var guids = ids.Split(new char[] { ',' }, StringSplitOptions.RemoveEmptyEntries).Select(x => Guid.Parse(x));
-            var result = new List<dynamic>();
-            foreach (var guid in guids)
-            {
-                var revision = repo.PublishedOrCurrentRevisions(guid).FirstOrDefault();
-                var variant = apiHelper.PathLocalisation(revision.Path);
-                result.Add(new { path = revision.Path.ToLower(), variant = variant });
-            }
-            return Json(result);
-        }
         [Authorize(Roles = PuckRoles.Localisation, AuthenticationSchemes = Mvc.AuthenticationScheme)]
         [HttpPost]
         public JsonResult Localisation(string p_path, string variant)
@@ -541,7 +528,8 @@ public JsonResult Localisation(string p_path, string variant)
             bool success = false;
             try
             {
-                apiHelper.SetLocalisation(p_path, variant);
+                if (apiHelper.PathLocalisation(p_path) != variant)
+                    apiHelper.SetLocalisation(p_path, variant);
                 success = true;
             }
             catch (Exception ex)
@@ -551,6 +539,19 @@ public JsonResult Localisation(string p_path, string variant)
             }
             return Json(new { message = message, success = success });
         }
+        [Authorize(Roles = PuckRoles.Puck, AuthenticationSchemes = Mvc.AuthenticationScheme)]
+        public JsonResult RootsLocalisations(string ids)
+        {
+            var guids = ids.Split(new char[] { ',' }, StringSplitOptions.RemoveEmptyEntries).Select(x => Guid.Parse(x));
+            var result = new List<dynamic>();
+            foreach (var guid in guids)
+            {
+                var revision = repo.PublishedOrCurrentRevisions(guid).FirstOrDefault();
+                var variant = apiHelper.PathLocalisation(revision.Path);
+                result.Add(new { path = revision.Path.ToLower(), variant = variant });
+            }
+            return Json(result);
+        }
         [Authorize(Roles = PuckRoles.ChangeType, AuthenticationSchemes = Mvc.AuthenticationScheme)]
         public ActionResult ChangeTypeDialog(Guid id)
         {

core/Controllers/BaseController.cs

@@ -158,7 +158,7 @@ public string GetVariant(string searchPath)
             if (!PuckCache.PathToLocale.TryGetValue(searchPath, out variant))
             {
                 foreach (var entry in PuckCache.PathToLocale)
-                {
+                {//PathToLocale dictionary ordered by depth descending (based on number of forward slashes in path) so it's safe to break after first match
                     if ((searchPath+"/").StartsWith(entry.Key+"/"))
                     {
                         variant = entry.Value;