Skip to content

"Overload for get()" #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

"Overload for get()" #8

wants to merge 2 commits into from

Conversation

andreeaiyopeso
Copy link

No description provided.

pbrosteanu
pbrosteanu reviewed Jan 13, 2023
View reviewed changes
Copy link

@pbrosteanu pbrosteanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also bump the version in the pom.xml file

pbrosteanu
pbrosteanu requested changes Jan 20, 2023
View reviewed changes
Copy link

@pbrosteanu pbrosteanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add more logic in the RequestParser, etc.
Always test code before creating pull requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbrosteanu pbrosteanu pbrosteanu requested changes

@leonardmustatea leonardmustatea leonardmustatea approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreeaiyopeso @pbrosteanu @leonardmustatea