Bump @slack/bolt version and make slackApp available globally #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed a preview of this PR to https://pr-191-internal.dev.ystv.co.uk |
Also add invariant checks to ensure multiple apps aren't created
There was a problem hiding this comment.
Copilot reviewed 6 out of 16 changed files in this pull request and generated no suggestions.
Files not reviewed (10)
- package.json: Language not supported
- features/calendar/check_with_tech.ts: Evaluated as low risk
- server/index.ts: Evaluated as low risk
- features/userFeedback/index.ts: Evaluated as low risk
- features/calendar/check_with_tech_actions.ts: Evaluated as low risk
- app/(authenticated)/calendar/[eventID]/actions.ts: Evaluated as low risk
- app/(authenticated)/calendar/[eventID]/signUpSheetActions.ts: Evaluated as low risk
- lib/auth/slack/index.ts: Evaluated as low risk
- components/slack/SlackUserInfo.tsx: Evaluated as low risk
- components/slack/SlackChannelsProvider.tsx: Evaluated as low risk
Comments skipped due to low confidence (1)
lib/slack/slackApiConnection.ts:27
- The error message should indicate that a global app does not exist, as the function is supposed to create one if it doesn't. Suggested message: "createSlackApp was called but a global app does not exist".
invariant((globalThis as unknown as { slackApp: App | undefined }).slackApp, "createSlackApp was called but a global app already exists");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the console spam of slack struggling to stay connected and also only require one slackApp to be made per instance running.