Merge pull request #5000 from chrishavlin/ensure_slice_coord_has_units

BUG: ensure YTSlice.coord has units

Author: jzuhone

yt/data_objects/selection_objects/slices.py

@@ -6,6 +6,7 @@
 )
 from yt.data_objects.static_output import Dataset
 from yt.funcs import (
+    fix_length,
     is_sequence,
     iter_fields,
     validate_3d_array,
@@ -78,7 +79,7 @@ def __init__(
         validate_object(data_source, YTSelectionContainer)
         YTSelectionContainer2D.__init__(self, axis, ds, field_parameters, data_source)
         self._set_center(center)
-        self.coord = coord
+        self.coord = fix_length(coord, ds)
 
     def _generate_container_field(self, field):
         xax = self.ds.coordinates.x_axis[self.axis]

yt/data_objects/tests/test_sph_data_objects.py

@@ -64,6 +64,16 @@ def test_slice():
 }
 
 
+def test_slice_to_frb():
+    ds = fake_sph_orientation_ds()
+    frb = ds.slice(0, 0.5).to_frb(ds.domain_width[0], (64, 64))
+    ref_vals = frb["gas", "density"]
+    for center in ((0.5, "code_length"), (0.5, "cm"), ds.quan(0.5, "code_length")):
+        frb = ds.slice(0, center).to_frb(ds.domain_width[0], (64, 64))
+        vals = frb["gas", "density"]
+        assert_equal(vals, ref_vals)
+
+
 def test_region():
     ds = fake_sph_orientation_ds()
     for (left_edge, right_edge), answer in REGION_ANSWERS.items():

yt/funcs.py

@@ -1106,7 +1106,7 @@ def validate_3d_array(obj):
 def validate_float(obj):
     """Validates if the passed argument is a float value.
 
-    Raises an exception if `obj` is a single float value
+    Raises an exception if `obj` is not a single float value
     or a YTQuantity of size 1.
 
     Parameters