Skip to content

Commit ca3a41b

Browse files
authored
Merge pull request #5008 from neutrinoceros/hotfix_typechecking
TYP: hotfix unsolvable type-checking requirements
2 parents 706e970 + cf54d48 commit ca3a41b

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

.github/workflows/type-checking.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ on:
77
pull_request:
88
paths:
99
- yt/**/*.py
10-
- setup.cfg
10+
- pyproject.toml
11+
- requirements/typecheck.txt
1112
- .github/workflows/type-checking.yaml
1213
workflow_dispatch:
1314

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ answer-testing = "yt.utilities.answer_testing.framework:AnswerTesting"
8181

8282
[project.optional-dependencies]
8383
# some generic, reusable constraints on optional-deps
84-
HDF5 = ["h5py>=3.1.0"]
84+
HDF5 = ["h5py>=3.1.0,!=3.12.0; platform_system=='Windows'"] # see https://github.com/h5py/h5py/issues/2505
8585
netCDF4 = ["netCDF4!=1.6.1,>=1.5.3"] # see https://github.com/Unidata/netcdf4-python/issues/1192
8686
Fortran = ["f90nml>=1.1"]
8787

requirements/typecheck.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ mypy==1.11.2
22
types-PyYAML==6.0.12.20240808
33
types-chardet==5.0.4.6
44
types-requests==2.32.0.20240907
5-
typing-extensions==4.4.0; python_version < '3.12'
5+
typing-extensions==4.6.0; python_version < '3.12'

yt/data_objects/construction_data_containers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1426,7 +1426,7 @@ class YTSmoothedCoveringGrid(YTCoveringGrid):
14261426
filename = None
14271427
_min_level = None
14281428

1429-
@wraps(YTCoveringGrid.__init__)
1429+
@wraps(YTCoveringGrid.__init__) # type: ignore [misc]
14301430
def __init__(self, *args, **kwargs):
14311431
ds = kwargs["ds"]
14321432
self._base_dx = (

0 commit comments

Comments
 (0)