Merge pull request #5181 from neutrinoceros/rfc/cleanup_legacy_imports

RFC: cleanup some unneeded legacy imports

Author: neutrinoceros

yt/funcs.py

@@ -274,11 +274,7 @@ def insert_ipython(num_up=1):
     """
     import IPython
     from IPython.terminal.embed import InteractiveShellEmbed
-
-    try:
-        from traitlets.config.loader import Config
-    except ImportError:
-        from IPython.config.loader import Config
+    from traitlets.config.loader import Config
 
     frame = inspect.stack()[num_up]
     loc = frame[0].f_locals.copy()

yt/utilities/command_line.py

@@ -687,6 +687,7 @@ def __call__(self, args):
             print("Could not load file.")
             sys.exit()
         import IPython
+        from traitlets.config.loader import Config
 
         import yt
 
@@ -695,11 +696,6 @@ def __call__(self, args):
         local_ns["pf"] = args.ds
         local_ns["yt"] = yt
 
-        try:
-            from traitlets.config.loader import Config
-        except ImportError:
-            from IPython.config.loader import Config
-
         cfg = Config()
         # prepend sys.path with current working directory
         sys.path.insert(0, "")

yt/visualization/fits_image.py

@@ -655,14 +655,10 @@ def to_glue(self, label="yt", data_collection=None):
         add a *label*. If you are already within the Glue environment, you
         can pass a *data_collection* object, otherwise Glue will be started.
         """
+        from glue.app.qt.application import GlueApplication
         from glue.core import Data, DataCollection
         from glue.core.coordinates import coordinates_from_header
 
-        try:
-            from glue.app.qt.application import GlueApplication
-        except ImportError:
-            from glue.qt.glue_application import GlueApplication
-
         image = Data(label=label)
         image.coords = coordinates_from_header(self.wcs.to_header())
         for k in self.fields: