From f5b925b4c40ddcb795d58c4a64face16ba7d47cf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Robert?= Date: Wed, 27 Aug 2025 07:31:40 +0200 Subject: [PATCH] BUG: fix an incoming deprecation warning from numpy 2.4 (np.minimum and np.maximum's out argument must be passed as keyword) --- yt/fields/field_functions.py | 2 +- yt/frontends/tipsy/io.py | 4 ++-- yt/utilities/amr_kdtree/amr_kdtools.py | 2 +- yt/utilities/initial_conditions.py | 2 +- yt/visualization/volume_rendering/old_camera.py | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/yt/fields/field_functions.py b/yt/fields/field_functions.py index 12db58bef47..ac1e41531f0 100644 --- a/yt/fields/field_functions.py +++ b/yt/fields/field_functions.py @@ -30,7 +30,7 @@ def get_radius(data, field_prefix, ftype): np.abs(r, r) np.subtract(r, DW.d[i], rdw) np.abs(rdw, rdw) - np.minimum(r, rdw, r) + np.minimum(r, rdw, out=r) np.multiply(r, r, r) np.add(radius2.d, r, radius2.d) if data.ds.dimensionality < i + 1: diff --git a/yt/frontends/tipsy/io.py b/yt/frontends/tipsy/io.py index 1c9b55ba645..f72c4ba5fa0 100644 --- a/yt/frontends/tipsy/io.py +++ b/yt/frontends/tipsy/io.py @@ -266,7 +266,7 @@ def _update_domain(self, data_file): pp["Coordinates"]["y"].min(), pp["Coordinates"]["z"].min(), ], - mi, + out=mi, ) np.maximum( ma, @@ -275,7 +275,7 @@ def _update_domain(self, data_file): pp["Coordinates"]["y"].max(), pp["Coordinates"]["z"].max(), ], - ma, + out=ma, ) ind += c # We extend by 1%. diff --git a/yt/utilities/amr_kdtree/amr_kdtools.py b/yt/utilities/amr_kdtree/amr_kdtools.py index 01d7327a267..8d9f59ebe67 100644 --- a/yt/utilities/amr_kdtree/amr_kdtools.py +++ b/yt/utilities/amr_kdtree/amr_kdtools.py @@ -27,7 +27,7 @@ def receive_and_reduce(comm, incoming_rank, image, add_to_front, *, use_opacity= return image ta = 1.0 - front[:, :, 3] - np.maximum(ta, 0.0, ta) + np.maximum(ta, 0.0, out=ta) # This now does the following calculation, but in a memory # conservative fashion # image[:,:,i ] = front[:,:,i] + ta*back[:,:,i] diff --git a/yt/utilities/initial_conditions.py b/yt/utilities/initial_conditions.py index 20845252a3f..7dbc14d799d 100644 --- a/yt/utilities/initial_conditions.py +++ b/yt/utilities/initial_conditions.py @@ -38,7 +38,7 @@ def __call__(self, grid, sub_select=None): cr2 = self.core_radius**2 for i, ax in enumerate("xyz"): np.add(r, (grid[ax] - self.center[i]) ** 2.0, r) - np.maximum(r, cr2, r) + np.maximum(r, cr2, out=r) ind = r <= r2 if sub_select is not None: ind &= sub_select diff --git a/yt/visualization/volume_rendering/old_camera.py b/yt/visualization/volume_rendering/old_camera.py index 00618bbc1f7..340fe1ddc0c 100644 --- a/yt/visualization/volume_rendering/old_camera.py +++ b/yt/visualization/volume_rendering/old_camera.py @@ -2173,8 +2173,8 @@ def _render(self, double_check, num_threads, image, sampler): + width / 2.0 * off2 * east_vector + width / 2.0 * off3 * normal_vector ) - np.minimum(mi, this_point, mi) - np.maximum(ma, this_point, ma) + np.minimum(mi, this_point, out=mi) + np.maximum(ma, this_point, out=ma) # Now we have a bounding box. data_source = ds.region(self.center, mi, ma)