fix(SalesChannel): in case of bad sales_channel getLocale() throws error

#122

Author: Gleb Galkin

src/api/__tests__/config_service_tests.js

@@ -44,6 +44,24 @@ test('Should return current locale, language and country code according to Sales
 
 });
 
+test('Should throw error if sales_channel is bad', async t => {
+  fetchMock.get('https://atlas-config-api.dc.zalan.do/api/config/CLIENT_ID-staging.json', configJson);
+
+  const sdk = await AtlasSDK.configure({
+    client_id: 'CLIENT_ID',
+    sales_channel: 'SALES_CHANNEL_BAD',
+    is_sandbox: true
+  }).catch(error => {
+    t.fail(error);
+  });
+
+  const error = t.throws(() => {
+    sdk.getLocale();
+  }, Error);
+
+  t.is(error.message, 'Cannot get locale for SALES_CHANNEL_BAD sales channel. This sales channel does not exists.');
+});
+
 test.afterEach.always(() => {
   fetchMock.restore();
 });

src/api/atlas_sdk_client.js

@@ -97,9 +97,16 @@ class AtlasSDKClient {
    * Returns locale based on sales channel, e.g. 'de_DE'
    * @method
    * @return {String} locale
+   * @throws Error - if sales channel doesn't exists for the client id, an Error is thrown.
    */
   getLocale() {
-    return this.config.salesChannels.find(sc => sc.channel === this.config.salesChannel).locale;
+    const salesChannel = this.config.salesChannels.find(sc => sc.channel === this.config.salesChannel);
+
+    if (salesChannel) {
+      return salesChannel.locale;
+    }
+
+    throw new Error(`Cannot get locale for ${this.config.salesChannel} sales channel. This sales channel does not exists.`);
   }
 
   /**