feat(gpu): add support for a custom device selection on multi-gpu mode #2245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdroalves
force-pushed
the
pa/feat/arbitrary_multi_gpus
branch
3 times, most recently
from
3ba3139 to
46e4f39
Compare
tmontaigu
reviewed
Apr 11, 2025
| @@ -341,10 +342,10 @@ impl Named for CompressedServerKey { | |||
| } | |||
|
|
|||
| #[cfg(feature = "gpu")] | |||
| #[derive(Clone)] | |||
tmontaigu
reviewed
Apr 11, 2025
pdroalves
force-pushed
the
pa/feat/arbitrary_multi_gpus
branch
2 times, most recently
from
dede9e5 to
78b8a44
Compare
tmontaigu
reviewed
May 9, 2025
Comment on lines
131
to
134
| // let gpus_to_be_used = (0..num_gpus).map(|i| { | ||
| // let gpu_idx = rng.gen_range(0..get_number_of_gpus()); | ||
| // GpuIndex::new(gpu_idx) | ||
| // }).collect_vec(); |
… a custom selection of GPUs
pdroalves
force-pushed
the
pa/feat/arbitrary_multi_gpus
branch
from
78b8a44 to
90b119c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/960
PR content/description
Check-list: