Ns/chore/fix zk thrpt elements #2933
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR content/description
Since the zk verification does not perform any pbs, the usual heuristic for throuhput elements count does not work. We use a different heuristic:
For
verify_and_expand, we use the classical pbs count and we take the lowest value between both heuristics.I also removed the zkv1 integer benches. This reduces a lot the bench time, allows to reduce clutter in the grafana dashboard and we bench zkv1 in the tfhe-zk-pok crates anyways