Skip to content

Conversation

@guillermo-oyarzun
Copy link
Member

@guillermo-oyarzun guillermo-oyarzun commented Oct 27, 2025

closes: please link all relevant issues

PR content/description

Add a new set of params to match the specialised classical on GPU on gaussian. We don't want to replace the current ones, cause that would affect the CPU

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

This change is Reviewable

Copy link
Contributor

@agnesLeroy agnesLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @guillermo-oyarzun! Some comments, also the core crypto benchmarks with 1_1 parameters should use this parameter set for GPU 🙏

@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feat/add-1-1-gaussian-params branch from 1fb919b to 57109ea Compare October 28, 2025 08:31
@guillermo-oyarzun
Copy link
Member Author

Thank you very much @guillermo-oyarzun! Some comments, also the core crypto benchmarks with 1_1 parameters should use this parameter set for GPU 🙏

I think in the way i did it it should also be using them cause i changed the bench_params alias, i will double check

@agnesLeroy
Copy link
Contributor

Thank you very much @guillermo-oyarzun! Some comments, also the core crypto benchmarks with 1_1 parameters should use this parameter set for GPU 🙏

I think in the way i did it it should also be using them cause i changed the bench_params alias, i will double check

Ah indeed you're right, looks good!

Copy link
Contributor

@agnesLeroy agnesLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IceTDrinker am I forgetting something here in the review? Is there anything else to do regarding parameters?

@IceTDrinker IceTDrinker self-requested a review October 28, 2025 09:31
@IceTDrinker
Copy link
Member

checking

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing missing is updating the vec all in the root of the v1_5 parameters so that security checks e.g. can run

That's why I would prefer an automated generation, but I know it's a tall order...

@IceTDrinker reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @agnesLeroy and @mayeul-zama)

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also may want to add it to the meta/gpu module ?

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @agnesLeroy and @mayeul-zama)

@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feat/add-1-1-gaussian-params branch from 57109ea to 4a4966a Compare October 28, 2025 11:20
@guillermo-oyarzun
Copy link
Member Author

The thing missing is updating the vec all in the root of the v1_5 parameters so that security checks e.g. can run

That's why I would prefer an automated generation, but I know it's a tall order...

@IceTDrinker reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @agnesLeroy and @mayeul-zama)

Ok i did it, not sure that the fact that now we have 141 elements in the vec can affect in something (considering before we always had 140)

@guillermo-oyarzun
Copy link
Member Author

you also may want to add it to the meta/gpu module ?

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @agnesLeroy and @mayeul-zama)

We commented and decided not to add them there, since we don't have a param set specifically for GPU for classical params, i would be strange to have only 1 param with a different naming.

@IceTDrinker
Copy link
Member

The thing missing is updating the vec all in the root of the v1_5 parameters so that security checks e.g. can run
That's why I would prefer an automated generation, but I know it's a tall order...

@IceTDrinker reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @agnesLeroy and @mayeul-zama)

Ok i did it, not sure that the fact that now we have 141 elements in the vec can affect in something (considering before we always had 140)

doesn't matter as long as you updated the the array size

@IceTDrinker
Copy link
Member

you also may want to add it to the meta/gpu module ?

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @agnesLeroy and @mayeul-zama)

We commented and decided not to add them there, since we don't have a param set specifically for GPU for classical params, i would be strange to have only 1 param with a different naming.

would likely be beneficial to have if you want the "parmater configurator" to be able to provide it to users

@IceTDrinker
Copy link
Member

parameter check in progress to make sure the addition to the all vec worked https://github.com/zama-ai/tfhe-rs/actions/runs/18875125723

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! and security run to check things is green, thanks !

@agnesLeroy agnesLeroy merged commit 0f0438c into main Oct 29, 2025
138 checks passed
@agnesLeroy agnesLeroy deleted the go/feat/add-1-1-gaussian-params branch October 29, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants