-
Notifications
You must be signed in to change notification settings - Fork 285
feat(gpu): add 1_1 classical pbs params for specialized version #2952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @guillermo-oyarzun! Some comments, also the core crypto benchmarks with 1_1 parameters should use this parameter set for GPU 🙏
1fb919b to
57109ea
Compare
I think in the way i did it it should also be using them cause i changed the bench_params alias, i will double check |
Ah indeed you're right, looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IceTDrinker am I forgetting something here in the review? Is there anything else to do regarding parameters?
|
checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing missing is updating the vec all in the root of the v1_5 parameters so that security checks e.g. can run
That's why I would prefer an automated generation, but I know it's a tall order...
@IceTDrinker reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @agnesLeroy and @mayeul-zama)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also may want to add it to the meta/gpu module ?
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @agnesLeroy and @mayeul-zama)
57109ea to
4a4966a
Compare
Ok i did it, not sure that the fact that now we have 141 elements in the vec can affect in something (considering before we always had 140) |
We commented and decided not to add them there, since we don't have a param set specifically for GPU for classical params, i would be strange to have only 1 param with a different naming. |
doesn't matter as long as you updated the the array size |
would likely be beneficial to have if you want the "parmater configurator" to be able to provide it to users |
|
parameter check in progress to make sure the addition to the all vec worked https://github.com/zama-ai/tfhe-rs/actions/runs/18875125723 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! and security run to check things is green, thanks !
closes: please link all relevant issues
PR content/description
Add a new set of params to match the specialised classical on GPU on gaussian. We don't want to replace the current ones, cause that would affect the CPU
Check-list:
This change is