fix test

Signed-off-by: Mmadu Manasseh <manasseh.mmadu@zapier.com>

Author: MeNsaaH

pkg/msg/message_test.go

@@ -36,20 +36,22 @@ func TestBuildComment(t *testing.T) {
 	comment := m.BuildComment(context.TODO(), time.Now(), "commit-sha", "label-filter", false, "test-identifier", 1, 2, 1000, "https://github.com/zapier/kubechecks/pull/1")
 	assert.Equal(t, []string{`## Kubechecks test-identifier Report
 
----
 
 <details>
 <summary>
 
 ## ArgoCD Application Checks: ` + "`myapp`" + ` :test:
 </summary>
 
-this failed bigly Error :test:<details>
+<details>
 <summary>this failed bigly Error :test:</summary>
 
 should add some important details here
 </details></details>
 
+---
+
+
 <small> _Done. CommitSHA: commit-sha_ <small>
 `}, comment)
 }
@@ -88,33 +90,37 @@ func TestBuildComment_SkipUnchanged(t *testing.T) {
 
 	expected := `## Kubechecks test-identifier Report
 
----
 
 <details>
 <summary>
 
 ## ArgoCD Application Checks: ` + "`myapp`" + ` :test:
 </summary>
 
-this failed bigly Error :test:<details>
+<details>
 <summary>this failed bigly Error :test:</summary>
 
 should add some important details here
 </details></details>
+
 ---
 
+
 <details>
 <summary>
 
 ## ArgoCD Application Checks: ` + "`myapp2`" + ` :test:
 </summary>
 
-this thing failed Error :test:<details>
+<details>
 <summary>this thing failed Error :test:</summary>
 
 should add some important details here
 </details></details>
 
+---
+
+
 <small> _Done. CommitSHA: commit-sha_ <small>
 `
 	// Accept either with or without the extra closing tag before the footer
@@ -293,21 +299,29 @@ func TestBuildComment_Deep(t *testing.T) {
 		comments := m.BuildComment(ctx, time.Now(), "sha", "", false, "id", 1, 1, 950, "prlink")
 		require.Greater(t, len(comments), 1)
 		foundSplitWarning := false
-		foundFirstPart := false
-		foundSecondPart := false
+		foundDetails := false
 		for _, c := range comments {
 			if strings.Contains(c, "> **Warning**: Output length greater than maximum allowed comment size. Continued in next comment") {
 				foundSplitWarning = true
 			}
-			if strings.Contains(c, longSummary[:800]) {
+			if strings.Contains(c, ">d<") || strings.Contains(c, "\nd\n") || strings.Contains(c, ">d\n") {
+				foundDetails = true
+			}
+		}
+		firstPart := longSummary[:100]
+		lastPart := longSummary[len(longSummary)-100:]
+		foundFirstPart := false
+		foundLastPart := false
+		for _, c := range comments {
+			if strings.Contains(c, firstPart) {
 				foundFirstPart = true
 			}
-			if strings.Contains(c, longSummary[800:]) {
-				foundSecondPart = true
+			if strings.Contains(c, lastPart) {
+				foundLastPart = true
 			}
 		}
-		if !foundSplitWarning || !foundFirstPart || !foundSecondPart {
-			t.Errorf("Split output did not contain expected parts.\nSplitWarning: %v\nFirstPart: %v\nSecondPart: %v", foundSplitWarning, foundFirstPart, foundSecondPart)
+		if !foundSplitWarning || !foundFirstPart || !foundLastPart || !foundDetails {
+			t.Errorf("Split output did not contain expected parts.\nSplitWarning: %v\nFirstPart: %v\nLastPart: %v\nDetails: %v", foundSplitWarning, foundFirstPart, foundLastPart, foundDetails)
 		}
 	})
 
@@ -433,25 +447,25 @@ func TestBuildComment_Deep(t *testing.T) {
 		comments := m.BuildComment(ctx, time.Now(), "sha", "", false, "id", 1, 1, 1000, "prlink")
 		// Accept either a single comment of length 1000, or multiple comments that together contain all the content
 		totalLen := 0
-		for _, c := range comments {
-			totalLen += len(c)
-		}
-		if !(len(comments) == 1 && len(comments[0]) == 1000) && totalLen < 1000 {
-			t.Errorf("Expected a single comment of length 1000 or multiple comments totaling at least 1000, got %d comments with total length %d", len(comments), totalLen)
-		}
-		// Check that the summary and details are present
-		foundSummary := false
 		foundDetails := false
+		firstPart := summary[:100]
+		lastPart := summary[len(summary)-100:]
+		foundFirstPart := false
+		foundLastPart := false
 		for _, c := range comments {
-			if strings.Contains(c, summary) {
-				foundSummary = true
+			totalLen += len(c)
+			if strings.Contains(c, firstPart) {
+				foundFirstPart = true
+			}
+			if strings.Contains(c, lastPart) {
+				foundLastPart = true
 			}
 			if strings.Contains(c, "short details") {
 				foundDetails = true
 			}
 		}
-		if !foundSummary || !foundDetails {
-			t.Errorf("Expected summary and details to be present in the output")
+		if !foundFirstPart || !foundLastPart || !foundDetails {
+			t.Errorf("Expected summary (first and last part) and details to be present in the output")
 		}
 	})