Add pilot review

Signed-off-by: Mmadu Manasseh <manasseh.mmadu@zapier.com>

Author: MeNsaaH

pkg/msg/message.go

@@ -226,6 +226,9 @@ func (m *Message) BuildComment(
 			comments = append(comments, sb.String())
 			sb.Reset()
 			sb.WriteString(header)
+			// continuedHeader contains both the header and the comment about the continued fromprevious comment
+			// header is written here but the rest of the content is written from the vcs PostMessage/UpdateMessage function
+			// that's why we're setting the contentLength to the length of the continuedHeader
 			contentLength = len(continuedHeader)
 
 		}

pkg/vcs/github_client/backoff.go

@@ -0,0 +1,20 @@
+package github_client
+
+import (
+	"time"
+
+	"github.com/cenkalti/backoff/v4"
+)
+
+// getBackOff returns a backoff pointer to use to retry requests
+func getBackOff() *backoff.ExponentialBackOff {
+
+	// Lets setup backoff logic to retry this request for 1 minute
+	bOff := backoff.NewExponentialBackOff()
+	bOff.InitialInterval = 60 * time.Second
+	bOff.MaxInterval = 10 * time.Second
+	bOff.RandomizationFactor = 0
+	bOff.MaxElapsedTime = 180 * time.Second
+
+	return bOff
+}

pkg/vcs/github_client/message.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"fmt"
 	"strings"
-	"time"
 
 	"github.com/cenkalti/backoff/v5"
 	"github.com/google/go-github/v62/github"
@@ -26,10 +25,8 @@ func (c *Client) PostMessage(ctx context.Context, pr vcs.PullRequest, message st
 
 	log.Debug().Msgf("Posting message to PR %d in repo %s", pr.CheckID, pr.FullName)
 
-	exponentialBackOff := backoff.NewExponentialBackOff()
-	exponentialBackOff.InitialInterval = 1 * time.Second
-	exponentialBackOff.Multiplier = 2
-	comment, err := backoff.Retry(context.TODO(), func() (*github.IssueComment, error) {
+	exponentialBackOff := getBackOff()
+	comment, err := backoff.Retry(ctx, func() (*github.IssueComment, error) {
 		cm, _, err := c.googleClient.Issues.CreateComment(
 			ctx,
 			pr.Owner,
@@ -61,10 +58,8 @@ func (c *Client) UpdateMessage(ctx context.Context, pr vcs.PullRequest, m *msg.M
 			var err error
 
 			repoNameComponents := strings.Split(m.Name, "/")
-			exponentialBackOff := backoff.NewExponentialBackOff()
-			exponentialBackOff.InitialInterval = 1 * time.Second
-			exponentialBackOff.Multiplier = 2
-			resp, err = backoff.Retry(context.TODO(), func() (*github.Response, error) {
+			exponentialBackOff := getBackOff()
+			resp, err = backoff.Retry(ctx, func() (*github.Response, error) {
 				comment, resp, err = c.googleClient.Issues.EditComment(
 					ctx,
 					repoNameComponents[0],

pkg/vcs/gitlab_client/message.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"fmt"
 	"strings"
-	"time"
 
 	"github.com/cenkalti/backoff/v5"
 	"github.com/pkg/errors"
@@ -23,11 +22,9 @@ func (c *Client) PostMessage(ctx context.Context, pr vcs.PullRequest, message st
 	_, span := tracer.Start(ctx, "PostMessage")
 	defer span.End()
 
-	exponentialBackOff := backoff.NewExponentialBackOff()
-	exponentialBackOff.InitialInterval = 1 * time.Second
-	exponentialBackOff.Multiplier = 2
+	exponentialBackOff := getBackOff()
 
-	n, err := backoff.Retry(context.TODO(), func() (*gitlab.Note, error) {
+	n, err := backoff.Retry(ctx, func() (*gitlab.Note, error) {
 		n, _, err := c.c.Notes.CreateMergeRequestNote(
 			pr.FullName, pr.CheckID,
 			&gitlab.CreateMergeRequestNoteOptions{
@@ -91,11 +88,9 @@ func (c *Client) UpdateMessage(ctx context.Context, pr vcs.PullRequest, m *msg.M
 
 	for i, msg := range messages {
 		if i == 0 {
-			exponentialBackOff := backoff.NewExponentialBackOff()
-			exponentialBackOff.InitialInterval = 1 * time.Second
-			exponentialBackOff.Multiplier = 2
+			exponentialBackOff := getBackOff()
 
-			n, err := backoff.Retry(context.TODO(), func() (*gitlab.Note, error) {
+			n, err := backoff.Retry(ctx, func() (*gitlab.Note, error) {
 				n, _, err := c.c.Notes.UpdateMergeRequestNote(m.Name, m.CheckID, m.NoteID, &gitlab.UpdateMergeRequestNoteOptions{
 					Body: pkg.Pointer(msg),
 				})