Skip to content

fix: Set success Git commit status in case of skipped checks #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix: Set success Git commit status in case of skipped checks #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc4b83d
fix: Set `success` Git commit status in case of skipped checks
andridzi Oct 22, 2024
651839d
do not forget about gitlab
andridzi Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/commitState.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ func (s CommitState) BareString() string {

var stateString = map[CommitState]string{
StateNone: "",
StateSkip: "Skipped",
StateSuccess: "Passed",
StateRunning: "Running",
StateWarning: "Warning",
Expand Down Expand Up @@ -62,6 +63,8 @@ func ParseCommitState(s string) (CommitState, error) {
return StateError, nil
case "panic":
return StatePanic, nil
case "skip", "skipped":
return StateSkip, nil
default:
return StateNone, fmt.Errorf("unknown commit state: %s", s)

Expand Down
2 changes: 1 addition & 1 deletion pkg/vcs/github_client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func toGithubCommitStatus(state pkg.CommitState) *string {
return pkg.Pointer("failure")
case pkg.StateRunning:
return pkg.Pointer("pending")
case pkg.StateSuccess, pkg.StateWarning, pkg.StateNone:
case pkg.StateSuccess, pkg.StateWarning, pkg.StateNone, pkg.StateSkip:
return pkg.Pointer("success")
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/vcs/gitlab_client/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func convertState(state pkg.CommitState) gitlab.BuildStateValue {
return gitlab.Running
case pkg.StateFailure, pkg.StateError, pkg.StatePanic:
return gitlab.Failed
case pkg.StateSuccess, pkg.StateWarning, pkg.StateNone:
case pkg.StateSuccess, pkg.StateWarning, pkg.StateNone, pkg.StateSkip:
return gitlab.Success
}

Expand Down
Loading