Skip to content

handle source.spec.helm.ignoreMissingValuesFiles = true #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

handle source.spec.helm.ignoreMissingValuesFiles = true #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/argo_client/manifests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,12 @@ func packageApp(ctx context.Context, source v1alpha1.ApplicationSource, refs []v
src := filepath.Join(refRepo.Directory, refPath)
dst := filepath.Join(tempDir, refPath)
if err = copyFile(src, dst); err != nil {
return "", errors.Wrapf(err, "failed to copy referenced value file: %q", valueFile)
// handle source.spec.helm.ignoreMissingValues = true
if errors.Is(err, os.ErrNotExist) && source.Helm.IgnoreMissingValueFiles {
log.Debug().Str("valueFile", valueFile).Msg("ignore missing values file, because source.Helm.IgnoreMissingValueFiles is true")
} else {
return "", errors.Wrapf(err, "failed to copy referenced value file: %q", valueFile)
}
}

relPath, err := filepath.Rel(tempAppDir, dst)
Expand Down
Loading