-
Notifications
You must be signed in to change notification settings - Fork 36
clean up dependabot configuration #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
djeebus
commented
Apr 14, 2025
- group minor & patch updates (over 1.0) into a single MR
- all others get their own MRs
1. group minor & patch updates (over 1.0) into a single MR 2. all others get their own MRs
Temporary image deleted. |
.github/dependabot.yml
Outdated
- "minor" | ||
- "patch" | ||
ignore: | ||
versions: "<1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you clarify again why we do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an assumption I've come to accept - if a project is before v1, it hasn't settled on an API, so changes are more likely to cause manual labor. I'd rather not let one or two <1 projects hold up easy merging for the rest of the upgrades, so this lets us move them into their own MRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably add a comment for that in the dependabot config. Sounds good to me!
.github/dependabot.yml
Outdated
- "minor" | ||
- "patch" | ||
ignore: | ||
versions: "<1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably add a comment for that in the dependabot config. Sounds good to me!
turns out we can't configure it this way