-
-
Notifications
You must be signed in to change notification settings - Fork 736
exim: Handle a wider range of request types in Sites Tree export #6403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Export request bodies for all HTTP methods, not just POST - Include the full raw body in the 'data' field without parsing parameters - Apply URL encoding to the entire body instead of just parameter names
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
What are you trying to achieve? (i.e. your use cases) |
@thc202 I'm trying to use ZAP to test apps that mostly use APIs (so most requests are JSON or XML), and export site trees that show which endpoints were found and what their requests looked like. |
Great job, no security vulnerabilities found in this Pull Request |
Thank you for this PR!
Thats not the use case for the Site Tree Export. If you want the full body then you should use another option. |
This might be a bit off-topic for the PR, but I'd really appreciate any suggestions here. I looked into the HAR export, which does include all the data I want, but it has a couple of drawbacks for my use case:
That's why I agree that including full request bodies in the Site Tree Export is not ideal either, so I'm happy to take this PR in whatever direction fits best with ZAP's goals. Just let me know what you think makes sense, and I'll give it a shot 😄 |
HAR should be highly compressible given that its text with high amounts of repetition. However, I guess HAR export could be updated to make response inclusion optional. |
Re your specific usecase, why not write a script to output whatever you want in whatever format you want? |
Overview
Purpose
Improve the Sites Tree export to handle a wider range of request types, including JSON and XML API requests.
Goals
Changes
application/x-www-form-urlencoded
; instead, the full raw body is exported after being URL-encodedRelated Issues
Fixes zaproxy/zaproxy#8941
Checklist
./gradlew spotlessApply
for code formattingFor more details, please refer to the developer rules and guidelines.