Reduce use of error level logging in pscan rules, tech detection, & retire #6645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
commented
Aug 6, 2025
| public void scanHttpResponseReceive(HttpMessage msg, int id, Source source) { | ||
|
|
||
| try { | ||
| LOGGER.debug( |
There was a problem hiding this comment.
This looks like a lot but it's because all the indentation changed.
There was a problem hiding this comment.
It is likely helpful to "Hide Whitespace" while reviewing this PR.
kingthorin
commented
Aug 6, 2025
| @Override | ||
| public void scanHttpResponseReceive(HttpMessage msg, int id, Source source) { | ||
|
|
||
| try { |
There was a problem hiding this comment.
This looks like a lot but it's because all the indentation changed.
kingthorin
commented
Aug 6, 2025
| public void scanHttpResponseReceive(HttpMessage msg, int id, Source source) { | ||
|
|
||
| // TODO: standardise the logic in the case of duplicate / conflicting headers. | ||
| try { |
There was a problem hiding this comment.
This looks like a lot but it's because all the indentation changed.
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
kingthorin
force-pushed
the
pscan-dont-log-at-error
branch
from
77572e5 to
518f493
Compare
kingthorin
force-pushed
the
pscan-dont-log-at-error
branch
from
518f493 to
0c65c0c
Compare
retire - Add change note. - Update logging in scan rules. Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
kingthorin
force-pushed
the
pscan-dont-log-at-error
branch
from
0c65c0c to
fe7bda8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview