-
-
Notifications
You must be signed in to change notification settings - Fork 734
client: Add Number of Browsers and Scope check to the client spider API #6692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Great job! No new security vulnerabilities introduced in this pull requestCommunicate with Checkmarx by submitting a PR comment with @Checkmarx followed by one of the supported commands. Learn about the supported commands here. |
Thanks! |
7c618dc
to
82b13e6
Compare
addOns/client/src/main/java/org/zaproxy/addon/client/spider/ClientSpiderApi.java
Outdated
Show resolved
Hide resolved
8674916
to
e85396e
Compare
e85396e
to
7caed93
Compare
Co-authored-by: Rick M <kingthorin@users.noreply.github.com> Signed-off-by: Nilson Magalhães <tenaz3@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview
This PR enhances the Client Spider API to expose concurrency and scope behavior controls, and documents them.
Add support for numberOfBrowsers (concurrency) to clientSpider/action/scan, wired to ClientOptions.setThreadCount(...).
Add support for scopeCheck to clientSpider/action/scan, wired to ClientOptions.setScopeCheck(...). Accepts FLEXIBLE (default) or STRICT.
Add i18n entries describing the new parameters in Messages.properties.
Update CHANGELOG.md (Unreleased → Added) to document the new API parameters.
Related Issues
Specify any related issues or pull requests by linking to them.