Skip to content

Conversation

tenaz3
Copy link
Contributor

@tenaz3 tenaz3 commented Aug 27, 2025

Overview

This PR enhances the Client Spider API to expose concurrency and scope behavior controls, and documents them.

  • Add support for numberOfBrowsers (concurrency) to clientSpider/action/scan, wired to ClientOptions.setThreadCount(...).

  • Add support for scopeCheck to clientSpider/action/scan, wired to ClientOptions.setScopeCheck(...). Accepts FLEXIBLE (default) or STRICT.

  • Add i18n entries describing the new parameters in Messages.properties.

  • Update CHANGELOG.md (Unreleased → Added) to document the new API parameters.

Related Issues

Specify any related issues or pull requests by linking to them.

@tenaz3 tenaz3 changed the title client: Add Number of Browsers to the client spider API client: Add Number of Browsers and Scope check to the client spider API Aug 27, 2025
@psiinon
Copy link
Member

psiinon commented Aug 27, 2025

Logo
Checkmarx One – Scan Summary & Detailseed61eba-310a-43c8-a1a8-482425cc0ea4

Great job! No new security vulnerabilities introduced in this pull request


Communicate with Checkmarx by submitting a PR comment with @Checkmarx followed by one of the supported commands. Learn about the supported commands here.

@psiinon
Copy link
Member

psiinon commented Aug 27, 2025

Thanks!
Could you also update this help page: https://github.com/zaproxy/zap-extensions/blob/main/addOns/client/src/main/javahelp/org/zaproxy/addon/client/resources/help/contents/spider-api.html

@tenaz3 tenaz3 force-pushed the setNumberOfBrowsers branch from 7c618dc to 82b13e6 Compare September 8, 2025 10:42
@tenaz3 tenaz3 force-pushed the setNumberOfBrowsers branch 2 times, most recently from 8674916 to e85396e Compare September 8, 2025 16:29
@tenaz3 tenaz3 requested a review from kingthorin September 9, 2025 16:03
@tenaz3 tenaz3 force-pushed the setNumberOfBrowsers branch from e85396e to 7caed93 Compare September 10, 2025 10:10
Co-authored-by: Rick M <kingthorin@users.noreply.github.com>
Signed-off-by: Nilson Magalhães <tenaz3@users.noreply.github.com>
@tenaz3 tenaz3 requested a review from kingthorin September 10, 2025 15:59
Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants