Skip to content

Make injector repo and gitea chart path configurable #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chiqomar opened this issue Apr 23, 2025 · 1 comment · May be fixed by #3752
Open

Make injector repo and gitea chart path configurable #3722

chiqomar opened this issue Apr 23, 2025 · 1 comment · May be fixed by #3752
Labels
enhancement ✨ New feature or request

Comments

@chiqomar
Copy link

Is your feature request related to a problem? Please describe.

We are currently composing and creating a version of our own zarf init, but references for artifacts, images, and charts have to be proxied. There is a way to do this registries using --registry-override, and for the gitea image using --set AGENT_IMAGE_DOMAIN, but there are two conspicuous ones where it is not configurable:

  • In packages/zarf-registry/zarf.yaml, the location of the injector binary is zarf-init-resources.s3.us-east-1.amazonaws.com; if this was a variable with a default, it would make things a little easier
  • In packages/gitea/zarf.yaml, dl.gitea.io is not overrideable, at least not easily.

Describe the behavior you'd like

Both of these values should be set as variables in their respective zarf.yaml files, and set to defaults with the current values. They should thus be overrideable using a --set flag on zarf package create

Describe alternatives you've considered

I am currently using a sed command to do this instead:

        sed -i-bk 's|zarf-init-resources\.s3\.us-east-1\.amazonaws.com|our-proxied-path.com|' packages/zarf-registry/zarf.yaml
        sed -i-bk 's|dl\.gitea\.io|our-proxied-path.com|' packages/gitea/zarf.yaml
        zarf package create . --confirm ...
@chiqomar chiqomar added the enhancement ✨ New feature or request label Apr 23, 2025
@brandtkeller
Copy link
Member

Thanks for the issue. I don't believe the requests here are unreasonable given efforts to make Init components more configurable. We welcome PR's otherwise we will get this on our backlog.

@github-project-automation github-project-automation bot moved this to Triage in Zarf Apr 23, 2025
@brandtkeller brandtkeller moved this from Triage to Backlog in Zarf Apr 23, 2025
@chiqomar chiqomar linked a pull request Apr 30, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
Status: Planned
Development

Successfully merging a pull request may close this issue.

2 participants