Skip to content

making vars for gitea chart repo and zarf injector #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chiqomar
Copy link

Description

Makes the gitea helm chart path (dl.gitea.io/charts) and the path to the zarf injector binary (zarf-init-resources.s3.us-east-1.amazonaws.com) variables in zarf-config.toml, so that we replace them as necessary, like other paths already can.

Related Issue

Fixes #3722

Checklist before merging

@chiqomar chiqomar requested review from a team as code owners April 30, 2025 16:16
Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit dd48068
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6814e5fed2bf340008ea9085

Signed-off-by: Omar Ahmad <chiqomar@hotmail.com>
@chiqomar chiqomar force-pushed the configurable-gitea-chart-and-injector-url branch from bceee25 to f2a877c Compare April 30, 2025 16:36
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the contribution. Couple items to resolve, otherwise this will be good to go.

@@ -6,6 +6,7 @@ agent_image_tag = 'local'

# Tag for the zarf injector binary to use
injector_version = '2025-03-24'
injector_domain = 'zarf-init-resources.s3.us-east-1.amazonaws.com'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I execute zarf dev inspect definition . at the root of the repository - I get the following for the injector

- name: zarf-injector
  description: |
    Bootstraps a Kubernetes cluster by cloning a running pod in the cluster and hosting the registry image.
    Removed and destroyed after the Zarf Registry is self-hosting the registry image.
  required: true
  only:
    cluster:
      architecture: arm64
  files:
  - source: packages/zarf-registry/https:/zarf-init-resources.s3.us-east-1.amazonaws.com/injector/2025-03-24/zarf-injector-arm64
    shasum: f68cf097ace34bdd04f6b1571a8d8ab4e04a27614dd7e752199ff09e21f4089b
    target: "###ZARF_TEMP###/zarf-injector"
    executable: true

We need to determine why this is malformed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's adding prepending the source path with the path to the imported package, without first checking if the file is a URL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah because templating happens after imports, Zarf doesn't see the file as a URL during imports and therefore adds the path to the imported component

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #3762 as the believed issue preventing this work from completion. We'll get it on our backlog - otherwise feel free to experiment with solutions in the PR if interested.

Co-authored-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
Signed-off-by: Omar Ahmad <chiqomar@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make injector repo and gitea chart path configurable
3 participants