-
Notifications
You must be signed in to change notification settings - Fork 189
making vars for gitea chart repo and zarf injector #3752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
making vars for gitea chart repo and zarf injector #3752
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Omar Ahmad <chiqomar@hotmail.com>
bceee25
to
f2a877c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the contribution. Couple items to resolve, otherwise this will be good to go.
@@ -6,6 +6,7 @@ agent_image_tag = 'local' | |||
|
|||
# Tag for the zarf injector binary to use | |||
injector_version = '2025-03-24' | |||
injector_domain = 'zarf-init-resources.s3.us-east-1.amazonaws.com' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I execute zarf dev inspect definition .
at the root of the repository - I get the following for the injector
- name: zarf-injector
description: |
Bootstraps a Kubernetes cluster by cloning a running pod in the cluster and hosting the registry image.
Removed and destroyed after the Zarf Registry is self-hosting the registry image.
required: true
only:
cluster:
architecture: arm64
files:
- source: packages/zarf-registry/https:/zarf-init-resources.s3.us-east-1.amazonaws.com/injector/2025-03-24/zarf-injector-arm64
shasum: f68cf097ace34bdd04f6b1571a8d8ab4e04a27614dd7e752199ff09e21f4089b
target: "###ZARF_TEMP###/zarf-injector"
executable: true
We need to determine why this is malformed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's adding prepending the source path with the path to the imported package, without first checking if the file is a URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah because templating happens after imports, Zarf doesn't see the file as a URL during imports and therefore adds the path to the imported component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #3762 as the believed issue preventing this work from completion. We'll get it on our backlog - otherwise feel free to experiment with solutions in the PR if interested.
Co-authored-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com> Signed-off-by: Omar Ahmad <chiqomar@hotmail.com>
Description
Makes the gitea helm chart path (dl.gitea.io/charts) and the path to the zarf injector binary (zarf-init-resources.s3.us-east-1.amazonaws.com) variables in zarf-config.toml, so that we replace them as necessary, like other paths already can.
Related Issue
Fixes #3722
Checklist before merging