Skip to content

Commit 23010da

Browse files
authored
don't test self-deletion in stateful tests (#3243)
* don't test self-deletion * don't alias * add explanatory comment
1 parent cea611b commit 23010da

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/zarr/testing/stateful.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -343,9 +343,10 @@ def delete_array_using_del(self, data: DataObject) -> None:
343343
@precondition(lambda self: len(self.all_groups) >= 2) # fixme don't delete root
344344
@rule(data=st.data())
345345
def delete_group_using_del(self, data: DataObject) -> None:
346-
group_path = data.draw(
347-
st.sampled_from(sorted(self.all_groups)), label="Group deletion target"
348-
)
346+
# ensure that we don't include the root group in the list of member names that we try
347+
# to delete
348+
member_names = tuple(filter(lambda v: "/" in v, sorted(self.all_groups)))
349+
group_path = data.draw(st.sampled_from(member_names), label="Group deletion target")
349350
prefix, group_name = split_prefix_name(group_path)
350351
note(f"Deleting group '{group_path=!r}', {prefix=!r}, {group_name=!r} using delete")
351352
members = zarr.open_group(store=self.model, path=group_path).members(max_depth=None)

0 commit comments

Comments
 (0)