Merge pull request #659 from Carreau/copy_attrs

Copy also attributes on root in copy_all

Author: Carreau

docs/release.rst

@@ -13,6 +13,8 @@ This release will be the first release of Zarr not supporting Python 3.5.
 * Add `Array` tests for FSStore.
   By :user:`Andrew Fulton <andrewfulton9>`; :issue: `644`.
 
+* fix a bug in which ``attrs`` would not be copied on the root when using ``copy_all``; :issue:`613`
+
 2.5.0
 -----
 

zarr/convenience.py

@@ -1065,6 +1065,7 @@ def copy_all(source, dest, shallow=False, without_attrs=False, log=None,
             n_copied += c
             n_skipped += s
             n_bytes_copied += b
+        dest.attrs.update(**source.attrs)
 
         # log a final message with a summary of what happened
         _log_copy_summary(log, dry_run, n_copied, n_skipped, n_bytes_copied)

zarr/tests/test_convenience.py

@@ -9,8 +9,18 @@
 from numcodecs import Adler32, Zlib
 from numpy.testing import assert_array_equal
 
-from zarr.convenience import (consolidate_metadata, copy, copy_store, load,
-                              open, open_consolidated, save, save_group)
+import zarr
+from zarr.convenience import (
+    consolidate_metadata,
+    copy,
+    copy_store,
+    load,
+    open,
+    open_consolidated,
+    save,
+    save_group,
+    copy_all,
+)
 from zarr.core import Array
 from zarr.errors import CopyError
 from zarr.hierarchy import Group, group
@@ -421,6 +431,31 @@ def check_copied_group(original, copied, without_attrs=False, expect_props=None,
         assert sorted(original.attrs.items()) == sorted(copied.attrs.items())
 
 
+def test_copy_all():
+    """
+    https://github.com/zarr-developers/zarr-python/issues/269
+
+    copy_all used to not copy attributes as `.keys()` does not return hidden `.zattrs`.
+
+    """
+    original_group = zarr.group(store=MemoryStore(), overwrite=True)
+    original_group.attrs["info"] = "group attrs"
+    original_subgroup = original_group.create_group("subgroup")
+    original_subgroup.attrs["info"] = "sub attrs"
+
+    destination_group = zarr.group(store=MemoryStore(), overwrite=True)
+
+    # copy from memory to directory store
+    copy_all(
+        original_group,
+        destination_group,
+        dry_run=False,
+    )
+
+    assert destination_group.attrs["info"] == "group attrs"
+    assert destination_group.subgroup.attrs["info"] == "sub attrs"
+
+
 # noinspection PyAttributeOutsideInit
 class TestCopy(unittest.TestCase):