Skip to content

Commit ffe9cb7

Browse files
committed
try to fix sync test races
1 parent 2022c04 commit ffe9cb7

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

zarr/tests/test_sync.py

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def _set_arange(arg):
6969
class MixinArraySyncTests(object):
7070

7171
def test_parallel_setitem(self):
72-
n = 20
72+
n = 100
7373

7474
# setup
7575
arr = self.create_array(shape=n * 1000, chunks=999, dtype='i4')
@@ -78,13 +78,16 @@ def test_parallel_setitem(self):
7878

7979
# parallel setitem
8080
future = pool.map_async(_set_arange, zip([arr] * n, range(n)))
81+
pool.close()
8182
results = sorted(future.get(60))
83+
pool.terminate()
84+
8285
print(results)
8386
eq(list(range(n)), results)
8487
assert_array_equal(np.arange(n * 1000), arr[:])
8588

8689
def test_parallel_append(self):
87-
n = 20
90+
n = 100
8891

8992
# setup
9093
arr = self.create_array(shape=1000, chunks=999, dtype='i4')
@@ -93,7 +96,10 @@ def test_parallel_append(self):
9396

9497
# parallel append
9598
future = pool.map_async(_append, zip([arr] * n, range(n)))
99+
pool.close()
96100
results = sorted(future.get(60))
101+
pool.terminate()
102+
97103
print(results)
98104
eq([((i+2)*1000,) for i in range(n)], results)
99105
eq(((n+1)*1000,), arr.shape)
@@ -181,10 +187,13 @@ def test_parallel_create_group(self):
181187

182188
# parallel create group
183189
n = 100
184-
results = pool.map_async(
190+
future = pool.map_async(
185191
_create_group, zip([g] * n, [str(i) for i in range(n)]))
186-
print(results.get(60))
192+
pool.close()
193+
results = sorted(future.get(60))
194+
pool.terminate()
187195

196+
print(results)
188197
eq(n, len(g))
189198

190199
def test_parallel_require_group(self):
@@ -195,10 +204,13 @@ def test_parallel_require_group(self):
195204

196205
# parallel require group
197206
n = 100
198-
results = pool.map_async(
207+
future = pool.map_async(
199208
_require_group, zip([g] * n, [str(i//10) for i in range(n)]))
200-
print(results.get(60))
209+
pool.close()
210+
results = sorted(future.get(60))
211+
pool.terminate()
201212

213+
print(results)
202214
eq(n//10, len(g))
203215

204216

0 commit comments

Comments
 (0)