Skip to content

gpui: Relax AssetLogger trait bounds #29450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025

Conversation

tidely
Copy link
Contributor

@tidely tidely commented Apr 25, 2025

Loosen trait bounds from std::error::Error to std::fmt::Display, since it's not required for the log::error! macro or any other bounds.

Specify that AssetLogger specifically logs errors in its documentation.

Use the futures::TryFutureExt trait extension to use inspect_err directly on a future.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 25, 2025
@maxdeviant maxdeviant changed the title gpui: Loosen AssetLogger trait bounds gpui: Relax AssetLogger trait bounds Apr 26, 2025
@mikayla-maki
Copy link
Member

Thanks!

@mikayla-maki mikayla-maki merged commit fde1cc7 into zed-industries:main Apr 29, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants