editor: Trim indent guides at last non-empty line #29482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
ronharel02
force-pushed
the
rharel/trim-indent-guides
branch
from
2f7dd5f to
61da916
Compare
Previously, when no non-empty lines where found when scanning ahead of an empty one, the empty line would inherit its parent block's depth. Changed this to fallback to 0, ensuring guides stop at the last non-empty line.
|
After looking further into |
ronharel02
force-pushed
the
rharel/trim-indent-guides
branch
from
61da916 to
e1dedea
Compare
AaronFeickert
approved these changes
May 1, 2025
|
Thanks! |
dive
pushed a commit
to dive/zed
that referenced
this pull request
May 12, 2025
Closes zed-industries#26274 Adjust the end position of indent guides to prevent them from extending through empty space. Also corrected old test values that seemed to have adapted to the indentation's behavior. Release Notes: - Fixed indentation guides extending beyond the final scope in a file.
osiewicz
pushed a commit
that referenced
this pull request
May 15, 2025
Closes #26274 Adjust the end position of indent guides to prevent them from extending through empty space. Also corrected old test values that seemed to have adapted to the indentation's behavior. Release Notes: - Fixed indentation guides extending beyond the final scope in a file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26274
Adjust the end position of indent guides to prevent them from extending through empty space.
Also corrected old test values that seemed to have adapted to the indentation's behavior.
Release Notes: