[Bug 🐞]: NRE on game loading

[krisavi]

Brief description of your issue (aka the problem)

Upon loading the save that hasn't been played for 3 years game crashes

Operating system

Windows 10

KSP version

1.12.5.3190

Version of addon

2.2.99.0-prerelease - <允许降落伞损坏> edition

Steps to reproduce the behavior or issue

1. Start game
2. Load game
3. Wait for it to load

Expected behavior

1. Start game
2. Load game
3. Wait for it to load
4. Play game

Actual behavior

1. Start game
2. Load game
3. Wait for it to load
4. Game crashes

Environment

Mod: 2.2.99.0-<WHATEVER CHINESE CHARACTERS>
KSP: 1.12.5.3190
Manual download from CurseForge because OverWolf/CurseForge application refuses to install
Relevant snippet from KSP.log in next portion.

Log files

In KSP.log 1747 times the following error:

[EXC 23:45:51.002] NullReferenceException: Object reference not set to an instance of an object
	OhScrap.BaseFailureModule.Initialize () (at <01ab19d437654295977ba3471f0631bc>:0)
	OhScrap.BaseFailureModule.FixedUpdate () (at <01ab19d437654295977ba3471f0631bc>:0)
	UnityEngine.DebugLogHandler:LogException(Exception, Object)
	ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
	UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

Screenshots

No response

Additional context

Save has been untouched for 2+ years

How did you download and install this?

CurseForge (download and manual installation)

[github-actions]

👍 Thank you @krisavi

❓❔

Have you reviewed the open issues logs and recent changelogs?

In order to help us help you, please provide:

• <KSP_ROOT>/KSP.LOG
• and one of the following:
  • if Module Manger is installed
    • <KSP_ROOT>/GameData/ModuleManager.ConfigCache
  • if Module Manger /L is installed
    • <KSP_ROOT>/PluginData\ModuleManager\ConfigCache.cfg
• Screenshots of issue (if appropriate) (images tell a much stronger tale)

You can archive these files (rar or zip, sadly no 7zip) and drag-n-drop them into an issue comment

📳👀Please either watch this repositiory for updates.

💬Kindly read our simple guides to:

• contributing
• our expected code of conduct (hint: we are all adults here)
• our style guide.md
  These are boilerplate.'

[PolarisWasInDenial]

Been having an identical issue just start occurring after my latest restart to apply fixes for KSPIE/Photon Sailor beamed power spamming the log;

Memory use within 5 minutes of opening the save is up to 25gb from KSP alone, with the exception only occurring within the KSC, not within the editor or flight.

KSP.log can be found here:
KSPIE_BeamedPower_CRITICAL-2.zip

ModuleManager.log and MMPatch.log
OhScrap_NRE_ModuleManager_Logs.zip

Save and .ckan OhScrapLogSpam_SaveAndCKAN_Modset.zip

And here's my modlist:
KSP: 1.12.5 (Win64) - Unity: 2019.4.18f1 - OS: Windows 10 (10.0.0) 64bit 000_AT_Utils - 1.10.1 ClickThroughBlocker - 2.1.10.21 Filter Extensions - 3.2.8 Harmony - 2.2.1 KSPBurst - 1.5.5.1 Toolbar - 1.8.0.8 USI Tools - 112.0.1 ToolbarControl - 0.1.9.9 CommunityPartsTitles - 0.9.3 KSP-Recall - 0.3.0.12 Ablative-Airbrake - 1.0.3 AbortPacks - 1.0.2 Achievements - 1.10.1.8 AIES_Patches - 0.0.1.3 AirPark - 1.7.1.7 Alarm Enhancements - 1.0.2 AllYAllContinued - 0.11.19.2 Animated Decouplers - 1.5 ASET Consolidated Agency - 2.0.2 ASET Consolidated Avionics Pack - 3.0 ASET Consolidated Props Pack - 2.0.2 ASET_ERS - 0.4.0.4 ASET_PRC - 0.1.0.5 Astrogator - 1.0 MOTHS - 0.0.1 AutoQuickSaveSystem - 0.1.0.6 Aviation Lights - 4.1.3 B9 Animation Modules - 1.7 B9 Part Switch - 2.20 B9 Aerospace - 6.6 B9 Aerospace HX Parts - 6.6 B9 HX Reconfig - 1.1 BD Animation Modules - 0.6.7.1 BAM - 1.3.3.4 Bavaria - 0.1 Benjee10_MMSEV - 1.0.2 Plume Party - 0.5 Benjee10_sharedAssets - 0.2.2 Mk.X-37B - 0.1.3.3 BetterSRBs - 1.2.6 BetterTimeWarpContinued - 2.3.13 BurstAtomicThrustModule - 0.1.0.3 CactEye Telescopes - 1.5.2.8 ChromaWorks - 2.0.0.1 ComfortableLanding - 2.0.2.5 CommNetAntennasExtension - 2.1.7 Community Category Kit - 0.1.0.112 Community Resource Pack - 112.0.1 CommunityTechTree - 3.4.4 Connected Living Space - 2.0.2 Contract Configurator - 2.2.2 Contract Pack: Exploration Plus - 2.0.1 Contract Pack: Clever Sats - 1.4 Contract Pack: CommNet Relays - 2.1 Contract Pack: Field Research - 1.2.2 Contract Pack: Kerbal Academy - 1.1.10 Contract Pack: Bases and Stations - 3.7.3 Contract Pack: Research Advancement Division - 1.2.1 Contract Pack: Tourism Plus - 1.5.2 Contract Pack: Tourism Expanded - 1.0.2 Crew Light - 1.20.1.1 CrewRandR - 1.1.11.4 Crowd Sourced Science - 6.0 CryoEngines - 2.0.6 CryoTanks - 1.6.5 Community Terrain Texture Pack - 1.0.5 Custom Asteroids - 1.9 CustomPrelaunchChecks - 1.8.1.1 DecouplerShroud - 0.8 DSCore - 3.2 ThorTech - 0.9.6.8 DeployableEngines - 1.3.1 DepthMask - 1.1.3 AGExt - 2.4.1.3 Distant Object Enhancement (DOE) /L - 2.1.1.11 DockingCamKURS - 1.3.8.5 DockRotate - 1.12.1.55 DynamicBatteryStorage - 2.2.5 Easy Vessel Switch - 2.3.7852.41352 Engine Lighting Relit - 1.6.3.4 Environmental Visual Enhancements - Redux - 1.11.7.1 EVAEnhancementsContinued - 0.1.15.3 ExtraplanetaryLaunchpads - 6.99.3 FarFutureTechnologies - 1.2 FASA - 7.2.7 Firespitter - 7.17 FMRS (Flight Manager For Reusable Stages) - 1.2.9.3 FreeIva - 0.2.10.2 FRS - 0.0.1.1 GasRepairsAndProbablyExpensiveSnacks - 1.0.2 ProgramaticExtensionAndRetraction - 1.0.2 FShangarExtender - 3.6.0.2 FTLDriveContinued - 0.2.5.2 Goo Pumps & Oils' Speed Pump - 1.9.0.11 GravityTurn - 1.8.3 GroundConstruction - 2.7.1 HabTechProps - 0.2 Hangar - 3.6.2.2 HeatControl - 0.6.1 HideEmptyTechTreeNodes - 1.3.2 Hooligan Labs Airships Core - 7.0.1 htRobotics - 1.0 HullcamVDSContinued - 0.2.2 Interstellar Fuel Switch - 3.30 JSIPartUtilities - 0.5.0.5 JSIAdvTransparentPods - 0.1.24 RasterPropMonitor - 0.31.11.1 Kerbal Aircraft Reactor Experiment - 1.1.1 KAS - 1.12.8285.34332 KAX - Kerbal Aircraft Expansion /L - 2.8.1 KerbalAtomics - 1.3.3 Kerbal Engineer Redux - 1.1.9 Kerbal Foundries - 2.4.8.18 KerbalGPS - 1.2.1.4 Kerbal Joint Reinforcement - 4.1.19 KerbalKonstructs - 1.8.6 WaterLaunchSites - 1.0.1 Precise Editor - 1.2 Kerbal Renamer - 1.7 Kerbal Reusability Expansion - 2.9.2 HyperEdit - 1.5.8 Feline Utility Rover - 1.3.6 Keridian Dynamics (KDVA) by Eleusis La Arwall - 0.8.99.6 InlineBallutes - 1.2.11.4 Kipard Skylon - 1.3 Kip Docking Ports - 1.0 Kerbal Inventory System - 1.29.8039.40483 Kopernicus - 1.12.1.158 kOS - 1.4 kOS-Astrogator - 0.2.2 kOS-KerbalEngineer - 0.1.1 KRASH - 0.5.33.5 KSP-AVC Plugin - 1.4.1.9 KSPCommunityFixes - 1.24.6 Ksp Craft Organizer - 1.7.2.2 KSPLogger - 0.6.1.1 KSPWheel - 0.16.14.33 KSP_PartVolume - 0.0.3.10 KSTS - 2.0.3 XT Landertron - 1.3 L-Tech Scientific Industries - 0.5.2.3 MandatoryRCS Part Pack - 1.4 ManeuverQueue - 0.5.0.2 Kerbal Dust Experiment - 2.0.2.14 Mini Sample Return Capsule (MSRC) - 1.4.2.2 Mk1-Cabin-Hatch - 1.0.1 MOARdV's Avionics Systems - 1.3.6 ModularFlightIntegrator - 1.2.10 ModuleAnimateGenericEffects - 0.1.5 Module Manager Watch Dog - 1.1.0.3 ModuleSequentialAnimateGeneric - 0.0.1.1 Moldavite Machines - 1.3 MunarIndustries Fuel Tank Expansion - 0.9.7.1 ZZZRadioTelescope - 1.0.5.1 NavBallDockingAlignmentIndicatorCE - 1.1.1.3 Docking Port Alignment Indicator - 6.10 NearFutureAeronautics - 2.1.1 NearFutureConstruction - 1.3.1 NearFutureElectrical - 1.2.3 NearFutureExploration - 1.1.2 NearFutureLaunchVehicles - 2.2 NearFutureProps - 0.7.1 NearFuturePropulsion - 1.3.5 NearFutureSolar - 1.3.2 NearFutureSpacecraft - 1.4.3 NeatherdyneMassDriver - 1.3.4.2 Lithobrake Exploration Technologies (LET) - 0.5.1 S.A.V.E - 1.11.0.3 NodeHelper - 1.5.1.5 NovaPunch Rebalanced - 0.1.7.3 Oblivion Aerospace (OAP) - 0.2.99 OhScrap! (OHS) by severedsolo - 2.2.99 On Demand Fuel Cells (ODFC) by Orum - 1.2.99.1 OuterPlanetsMod - 2.2.10 OPT Continued - 3.1.1 OPT Legacy Spaceplane Parts - 3.1.2 OPT Reconfig - 3.4.1 OrbitalTug - 1.3.1.2 PatchManager - 0.0.17.6 Persistent Rotation Upgraded - 1.9.1.7 Radial Experiment Storage Container - 2.5 Photon Sailor - 1.7.3 Kerbal Planetary Base Systems - 1.6.16 PlanetShine - 0.2.6.6 ProbeControlRoom - 1.3.1 Procedural Fairings - 6.3 PWBFuelBalancerRestored - 0.2.1.7 QuickSearch - 3.3.0.9 QuizTechAeroPackContinued - 1.3.15.1 Mk2.5 Spaceplane Parts - 1.5.3.1 RATPack - 0.4.3.4 RCS Build Aid - 1.0.6 RealChute - 1.4.8.3 RealPlume - Stock - 4.0.6 Recovery Controller - 0.0.4.1 ReentryParticleEffectRenewed - 1.9.1.1 RemoteTechRedevAntennas - 0.1.1 DeepFreeze Continued... - 0.31 ResearchBodies - 1.13 ResonantOrbitCalculator - 0.0.7 ReStock - 1.4.3 ReStockPlus - 1.4.3 RetractableLiftingSurface - 0.2.1.2 RLA_Reborn - 0.15.2 RoutineMissionManager - 0.4.0.2 SCANsat - 1.20.4 ScienceAlert - 1.9.10.2 ScienceLabInfo - 2.0.2 ScrapYard (SYD) - 2.2.99 PicoPort4AllSizes - 0.1.2.3 PicoPort - 0.1.6.4 RecoverableEmergencyKerbalTransport - 0.4.8.2 Ship Manifest - 6.0.6 Simple Adjustable Fairings - Plugin - 1.12 SmartParts - 1.9.17 SmartStage - 2.9.14.2 Solar Science (SOL) by Snoopy20111 - 1.3.1 SaveOurSettings - 0.0.1.4 SpacedockReBoxed - 0.3.0.4 SpaceDust - 0.4.4 Space Dust Unbound - 1.0.2 RecycledParts - 0.2.3 ButtonManager - 1.0.1.1 SpaceTuxLibrary - 0.0.8.5 VesselModuleSave - 1.0.1.2 Spacetux - 0.3.13.1 SpaceY Lifters (SYL) by NecroBones - 1.9.99 Spectra - 1.6.5 StandardPropulsionSystems - 1.0.6 MicroSat - 0.1.4.1 StageRecovery - 1.9.6.1 StarshipLaunchExpansion - 0.5 StationKeeping - 0.2.3 StationPartsExpansionRedux - 2.0.10 Surface Mounted Lights - 1.19.7854.4854 SystemHeat - 0.6 TacSelfDestructContinued - 1.7.0.3 TarsierSpaceTechnology - 7.13 TDProps - 1.4 TextureReplacer - 4.5.3 ThrottleControlledAvionics - 3.8.0.1 ThroughTheEyes - 2.0.4.4 TAC Life Support - 0.18 ToggleLadderExit - 0.0.1.2 Tracking Station Evolved - 1.0.7 Trajectories - 2.4.3 Kerbal Alarm Clock - 3.14 TrimIndicators - 0.1.0.4 TrimPlus - 1.4 TexturesUnlimitedFX - 1.0.5 Tundra Exploration - 6.1 Tundra Space Center - 2.0.2 Tundra Technologies - 6.0 TutorialFixes - 0.0.3 TweakScale - 2.4.6.25 TweakScale Companion - 2023.3.4 TweakScale Companion for Airplane Plus - 0.1 TweakScale Companion for Frameworks - 0.3 TweakScale Companion for Firespitter - 1.2 TweakScale Companion for Kerbal Inventory System (KIS) - 1.0.0.2 TweakScale Companion Living Style - 0.0.3 TweakScale Companion Multipass - 0.0.2 TweakScale Companion for Neist Airliner Parts - 0.0.1 TweakScale Companion for Orbit Portal Technologies (OPT) - 0.0.1 TweakScale Companion for Post Kerbin Mining Corporation Add'Ons - 2.2 TweakScale Companion for ReStockPlus - 1.1 TweakScale Companion Rockets - 0.0.1 TweakScale Companion for SMCE - 0.0.1.1 Asteroid Recycling Tech - 112.0.1 USI Exploration Pack - 112.0.10 Freight Transport Tech - 112.0.1 Karbonite - 112.0.1 Konstruction - 112.0.1 Malemute Rover - 112.0.1 MKS - 112.0.1 NuclearRockets - 112.0.1 Sounding Rockets - 112.0.1 USI Core - 112.0.1 Universal Storage 2 - 4.0.0.8 UrgentContracts - 0.1.1 VesselMover - 1.12 VesselViewerContinued - 0.8.8.6 KSP Interstellar Extended - 1.29.6 Waterfall - 0.9 WildBlueTools - 1.88.2 Kerbal Actuators - 1.8.5 WildBlueCore - 1.2.3 Blueshift - 1.9.4 Buffalo - 2.12 Buffalo2 - 1.5 Deep Space Exploration Vessels - 3.12 Airships - 2.19.1 Mk-33 - 1.3.2 Mark One Laboratory Extensions - 1.27 Pathfinder - 1.40.3 Sandcastle - 1.1.1 Snacks - 1.28

[PolarisWasInDenial]

Been having an identical issue just start occurring after my latest restart to apply fixes for KSPIE/Photon Sailor beamed power spamming the log; KSP.log can be found here: KSPIE_BeamedPower_CRITICAL-2.zip ModuleManager.log and MMPatch.log OhScrap_NRE_ModuleManager_Logs.zip

Save and .ckan OhScrapLogSpam_SaveAndCKAN_Modset.zip

Will add modlist in text form here momentarily.

I will note that this save is under one month old at the time of writing.

After 15 minutes, the log size reaches a full 1.2gb:
OhScrap_15minutesInSave_NRE.zip

If you would like to talk to me directly about this report, just send a message in the SpaceDock Discord's #mod-help channel, as I can respond far more readily there.

[keyspace]

I doubt the particular NRE listed in the original report could be the cause of a crash. It looks very similar to that in issue #46. If so, then this is a duplicate.

I've debugged it yesterday (see linked issue).

---

EDIT: Not sure about the other comments, though.