Skip to content

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Oct 14, 2025

Description

Upgrade cometBFT

Summary by CodeRabbit

  • Chores
    • Upgraded a core consensus dependency to the latest patch release to improve stability, compatibility, and security posture.
    • This maintenance update is not expected to change user-facing behavior or workflows.
    • Minor performance and reliability improvements may be observed under certain network conditions.
    • No configuration changes are required; existing setups should continue to work as before.

@lumtis lumtis requested a review from a team as a code owner October 14, 2025 15:27
@lumtis lumtis added the no-changelog Skip changelog CI check label Oct 14, 2025
Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Updated the go.mod to bump the cometbft/cometbft dependency from v0.38.17 to v0.38.19. No other files or exported signatures were changed.

Changes

Cohort / File(s) Summary
Dependency version bump
`go.mod`
Updated `cometbft/cometbft` from `v0.38.17` to `v0.38.19`. No other dependency or module metadata changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description only states “Upgrade cometBFT” and omits the required template sections, including a detailed summary with motivation, context, dependencies, and the “How Has This Been Tested?” section with test confirmations. Please expand the description to include a comprehensive summary of changes and context under the Description heading and complete the How Has This Been Tested section with checkboxes or details of local, integration, and CI tests conducted.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the primary change by indicating a chore to upgrade the CometBFT patch version, which directly reflects the update from v0.38.17 to v0.38.19 in the go.mod file. It is concise, clear, and focused on the main change without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7668f11 and 4b780ea.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: build-zetanode
  • GitHub Check: gosec
  • GitHub Check: lint
  • GitHub Check: build-and-test
  • GitHub Check: rpcimportable
  • GitHub Check: analyze (go)
  • GitHub Check: build

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.78%. Comparing base (9c40892) to head (5d6eaf9).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4337      +/-   ##
===========================================
- Coverage    65.80%   65.78%   -0.02%     
===========================================
  Files          466      466              
  Lines        34232    34240       +8     
===========================================
- Hits         22527    22526       -1     
- Misses       10713    10721       +8     
- Partials       992      993       +1     

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, just curious if we should merge non-zetaclient related changes to develop branch?

@lumtis
Copy link
Member Author

lumtis commented Oct 15, 2025

approved, just curious if we should merge non-zetaclient related changes to develop branch?

Since it's non consensus breaking, it's fine

@lumtis lumtis added this pull request to the merge queue Oct 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2025
@lumtis lumtis added this pull request to the merge queue Oct 15, 2025
Merged via the queue into develop with commit 8f50e59 Oct 15, 2025
48 checks passed
@lumtis lumtis deleted the chore/upgrade-comet-bft-patch-dev branch October 15, 2025 07:43
renan061 pushed a commit that referenced this pull request Oct 15, 2025
* chore: upgrade cometbft patch version

* chore: run go mod tidy
lumtis added a commit that referenced this pull request Oct 16, 2025
* chore: upgrade cometbft patch version

* chore: run go mod tidy
github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2025
* fix eth stress test timeout

* decrease default mempool threshold

* add minimum retry interval logic to internal tracker

* set PostVoteInboundGasLimit back to 500K; set block max gas to 50M

* avoid adding finalized or voted ballot to internal tracker cache

* rename DefaultMempoolSize as DefaultAppMempoolSize

* add changelog entry

* update time stamp only for first MaxInboundTrackersPerScan internal trackers

* print RPC error logs from ballotIsFinalizedOrVoted instead of ignore

* chore: upgrade cometbft patch version (#4337)

* chore: upgrade cometbft patch version

* chore: run go mod tidy

* refactor: set verbose logs for event parsing error as debug (#4345)

* change invalid event to debug

* skip ton log if zero logs

* generate

* chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.4.0 (#4334)

chore(deps): bump github.com/go-viper/mapstructure/v2

Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.2.1 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](go-viper/mapstructure@v2.2.1...v2.4.0)

---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
  dependency-version: 2.4.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump github.com/ulikunitz/xz from 0.5.11 to 0.5.14 (#4333)

Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.11 to 0.5.14.
- [Commits](ulikunitz/xz@v0.5.11...v0.5.14)

---
updated-dependencies:
- dependency-name: github.com/ulikunitz/xz
  dependency-version: 0.5.14
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4332)

Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.8 to 1.7.9.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](hashicorp/go-getter@v1.7.8...v1.7.9)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-getter
  dependency-version: 1.7.9
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* test: skip spawning Solana and Sui for ETH stress tests (#4346)

* update docker compose

* update init condition

* fix: update zetachain-exporter to v4.11.0 for localnet support (#4341)

* update zetachain-exporter to v4.11.0 for localnet support

* Update Makefile

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* chore: add precompile metadata for blockscout explorer (#4350)

* Adding ABI for precompiles

* added readmes

* updated metadata for bs

* fixed precompile version in metadata

* fixed abi format

* fixed compiler version

* renan comments

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: morde08 <peter@zetachain.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Charlie <31941002+CharlieMc0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Skip changelog CI check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants