Skip to content

Commit 0f3a8e6

Browse files
committed
link: print reloc type when reporting errors
1 parent ab741f5 commit 0f3a8e6

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/link/Elf/Atom.zig

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -539,8 +539,9 @@ fn reportTextRelocError(
539539
) RelocError!void {
540540
const diags = &elf_file.base.comp.link_diags;
541541
var err = try diags.addErrorWithNotes(1);
542-
try err.addMsg("relocation at offset 0x{x} against symbol '{s}' cannot be used", .{
542+
try err.addMsg("relocation at offset 0x{x} with type {} against symbol '{s}' cannot be used", .{
543543
rel.r_offset,
544+
relocation.fmtRelocType(rel.r_type(), elf_file.getTarget().cpu.arch),
544545
symbol.name(elf_file),
545546
});
546547
err.addNote("in {}:{s}", .{ self.file(elf_file).?.fmtPath(), self.name(elf_file) });
@@ -555,8 +556,9 @@ fn reportPicError(
555556
) RelocError!void {
556557
const diags = &elf_file.base.comp.link_diags;
557558
var err = try diags.addErrorWithNotes(2);
558-
try err.addMsg("relocation at offset 0x{x} against symbol '{s}' cannot be used", .{
559+
try err.addMsg("relocation at offset 0x{x} with type {} against symbol '{s}' cannot be used", .{
559560
rel.r_offset,
561+
relocation.fmtRelocType(rel.r_type(), elf_file.getTarget().cpu.arch),
560562
symbol.name(elf_file),
561563
});
562564
err.addNote("in {}:{s}", .{ self.file(elf_file).?.fmtPath(), self.name(elf_file) });
@@ -572,8 +574,9 @@ fn reportNoPicError(
572574
) RelocError!void {
573575
const diags = &elf_file.base.comp.link_diags;
574576
var err = try diags.addErrorWithNotes(2);
575-
try err.addMsg("relocation at offset 0x{x} against symbol '{s}' cannot be used", .{
577+
try err.addMsg("relocation at offset 0x{x} with type {} against symbol '{s}' cannot be used", .{
576578
rel.r_offset,
579+
relocation.fmtRelocType(rel.r_type(), elf_file.getTarget().cpu.arch),
577580
symbol.name(elf_file),
578581
});
579582
err.addNote("in {}:{s}", .{ self.file(elf_file).?.fmtPath(), self.name(elf_file) });

0 commit comments

Comments
 (0)