Skip to content

Commit f5d4fa5

Browse files
committed
stage1: elaborate on "unimplemented" in wasi.c
1 parent b7cb42f commit f5d4fa5

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

stage1/wasi.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,7 @@ uint32_t wasi_snapshot_preview1_fd_read(uint32_t fd, uint32_t iovs, uint32_t iov
517517
case wasi_filetype_character_device: break;
518518
case wasi_filetype_regular_file: break;
519519
case wasi_filetype_directory: return wasi_errno_inval;
520-
default: panic("unimplemented");
520+
default: panic("unimplemented: fd_read special file");
521521
}
522522

523523
size_t size = 0;
@@ -629,7 +629,7 @@ uint32_t wasi_snapshot_preview1_fd_pwrite(uint32_t fd, uint32_t iovs, uint32_t i
629629
case wasi_filetype_character_device: break;
630630
case wasi_filetype_regular_file: break;
631631
case wasi_filetype_directory: return wasi_errno_inval;
632-
default: panic("unimplemented");
632+
default: panic("unimplemented: fd_pwrite special file");
633633
}
634634

635635
fpos_t pos;
@@ -679,7 +679,7 @@ uint32_t wasi_snapshot_preview1_fd_filestat_set_times(uint32_t fd, uint64_t atim
679679
fprintf(stderr, "wasi_snapshot_preview1_fd_filestat_set_times(%u, %llu, %llu, 0x%X)\n", fd, (unsigned long long)atim, (unsigned long long)mtim, fst_flags);
680680
#endif
681681

682-
panic("unimplemented");
682+
panic("unimplemented: fd_filestat_set_times");
683683
return wasi_errno_success;
684684
}
685685

@@ -703,7 +703,7 @@ uint32_t wasi_snapshot_preview1_environ_get(uint32_t environ, uint32_t environ_b
703703
fprintf(stderr, "wasi_snapshot_preview1_environ_get()\n");
704704
#endif
705705

706-
panic("unimplemented");
706+
panic("unimplemented: environ_get");
707707
return wasi_errno_success;
708708
}
709709

@@ -757,7 +757,7 @@ uint32_t wasi_snapshot_preview1_fd_readdir(uint32_t fd, uint32_t buf, uint32_t b
757757
fprintf(stderr, "wasi_snapshot_preview1_fd_readdir(%u, 0x%X, %u, %llu)\n", fd, buf, buf_len, (unsigned long long)cookie);
758758
#endif
759759

760-
panic("unimplemented");
760+
panic("unimplemented: fd_readdir");
761761
return wasi_errno_success;
762762
}
763763

@@ -774,7 +774,7 @@ uint32_t wasi_snapshot_preview1_fd_write(uint32_t fd, uint32_t iovs, uint32_t io
774774
case wasi_filetype_character_device: break;
775775
case wasi_filetype_regular_file: break;
776776
case wasi_filetype_directory: return wasi_errno_inval;
777-
default: panic("unimplemented");
777+
default: panic("unimplemented: fd_write special file");
778778
}
779779

780780
size_t size = 0;
@@ -825,7 +825,7 @@ uint32_t wasi_snapshot_preview1_path_open(uint32_t fd, uint32_t dirflags, uint32
825825
fds[fd_len].fdflags = fdflags;
826826
switch (des[de].filetype) {
827827
case wasi_filetype_directory: fds[fd_len].stream = NULL; break;
828-
default: panic("unimplemented");
828+
default: panic("unimplemented: path_open non-directory DirEntry");
829829
}
830830
fds[fd_len].fs_rights_inheriting = fs_rights_inheriting;
831831

@@ -943,7 +943,7 @@ uint32_t wasi_snapshot_preview1_path_unlink_file(uint32_t fd, uint32_t path, uin
943943
enum wasi_errno lookup_errno = DirEntry_lookup(fd, 0, path_ptr, path_len, &de);
944944
if (lookup_errno != wasi_errno_success) return lookup_errno;
945945
if (des[de].filetype == wasi_filetype_directory) return wasi_errno_isdir;
946-
if (des[de].filetype != wasi_filetype_regular_file) panic("unimplemented");
946+
if (des[de].filetype != wasi_filetype_regular_file) panic("unimplemented: path_unlink_file special file");
947947
DirEntry_unlink(de);
948948
return wasi_errno_success;
949949
}
@@ -961,7 +961,7 @@ uint32_t wasi_snapshot_preview1_fd_pread(uint32_t fd, uint32_t iovs, uint32_t io
961961
case wasi_filetype_character_device: break;
962962
case wasi_filetype_regular_file: break;
963963
case wasi_filetype_directory: return wasi_errno_inval;
964-
default: panic("unimplemented");
964+
default: panic("unimplemented: fd_pread special file");
965965
}
966966

967967
fpos_t pos;
@@ -975,7 +975,7 @@ uint32_t wasi_snapshot_preview1_fd_pread(uint32_t fd, uint32_t iovs, uint32_t io
975975
if (fds[fd].stream != NULL)
976976
read_size = fread(&m[load32_align2(&iovs_ptr[i].ptr)], 1, len, fds[fd].stream);
977977
else
978-
panic("unimplemented");
978+
panic("unimplemented: fd_pread stream=NULL");
979979
size += read_size;
980980
if (read_size < len) break;
981981
}
@@ -1000,7 +1000,7 @@ uint32_t wasi_snapshot_preview1_fd_seek(uint32_t fd, uint64_t in_offset, uint32_
10001000
case wasi_filetype_character_device: break;
10011001
case wasi_filetype_regular_file: break;
10021002
case wasi_filetype_directory: return wasi_errno_inval;
1003-
default: panic("unimplemented");
1003+
default: panic("unimplemented: fd_seek special file");
10041004
}
10051005

10061006
if (fds[fd].stream == NULL) return wasi_errno_success;
@@ -1035,7 +1035,7 @@ uint32_t wasi_snapshot_preview1_poll_oneoff(uint32_t in, uint32_t out, uint32_t
10351035
fprintf(stderr, "wasi_snapshot_preview1_poll_oneoff(%u)\n", nsubscriptions);
10361036
#endif
10371037

1038-
panic("unimplemented");
1038+
panic("unimplemented: poll_oneoff");
10391039
return wasi_errno_success;
10401040
}
10411041

0 commit comments

Comments
 (0)