Skip to content

#23358 adds ldexpf, ldexp, ldexpl to compiler_rt #24005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

hi7
Copy link
Contributor

@hi7 hi7 commented May 28, 2025

Please correct me if I'm wrong...

Closes #23358

@alexrp alexrp self-assigned this May 28, 2025
@alexrp
Copy link
Member

alexrp commented May 28, 2025

If our vendored musl and MinGW-w64 sources contain implementations for these, they should be removed as part of this.

@hi7
Copy link
Contributor Author

hi7 commented May 28, 2025

If our vendored musl and MinGW-w64 sources contain implementations for these, they should be removed as part of this.

Do you mean the removing the entries in src/libs/mingw.zig and src/libs/musl.zig or different ones?

@alexrp
Copy link
Member

alexrp commented May 28, 2025

Yes, and the actual C files.

@hi7
Copy link
Contributor Author

hi7 commented May 28, 2025

I don't find w64 entries in src/libs/mingw.zig only w32.

@hi7
Copy link
Contributor Author

hi7 commented May 28, 2025

OK I close this Pull Request if nothing speaks against it as I use the implementation of std.math.ldexp in my last commit like it is already done in `#24006'. To avoid duplicate open Issues I would close this one.

@hi7
Copy link
Contributor Author

hi7 commented May 29, 2025

Parallel development with #24006

@hi7 hi7 closed this May 29, 2025
@alexrp alexrp removed their assignment May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasm-ld: ....o: undefined symbol: ldexp in Release modes, but works in Debug
2 participants