Skip to content

Conversation

3reality-support
Copy link

@3reality-support 3reality-support commented Oct 9, 2025

Proposed change

This PR added adaptation code for door_sensor and added 1 additional private cluster

  1. open_delay_time: set for 5 seconds, after triggering, display on after 5 seconds

Additional information

2f8a7a35c0428774d368d5c20bbb7729

Device diagnostics

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.13%. Comparing base (500e74e) to head (be8cf1f).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4379   +/-   ##
=======================================
  Coverage   92.12%   92.13%           
=======================================
  Files         358      359    +1     
  Lines       11917    11929   +12     
=======================================
+ Hits        10979    10991   +12     
  Misses        938      938           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheJulianJES TheJulianJES added the manufacturer This request was made by the device's manufacturer label Oct 10, 2025
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks!

For others looking at this PR: Having the "open delay time" be device specific might actually be useful if binding the OnOff cluster to a light, for example.
Since this device provides the option, we should allow for configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manufacturer This request was made by the device's manufacturer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants