Skip to content

Conversation

3reality-support
Copy link

@3reality-support 3reality-support commented Oct 10, 2025

Proposed change

This PR added adaptation code for dual_plug and added 2 additional private clusters

  1. on_to_off_delay---off delay, when you set the attribute to 10 and the current status is on, it will change to off after 10 seconds
  2. off_to_on_delay---on delay, similar to the above

Additional information

9cebdaa5-95ab-46be-8b48-5dccfc5d02fe

Device diagnostics

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.13%. Comparing base (500e74e) to head (5c64433).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4383   +/-   ##
=======================================
  Coverage   92.12%   92.13%           
=======================================
  Files         358      359    +1     
  Lines       11917    11930   +13     
=======================================
+ Hits        10979    10992   +13     
  Misses        938      938           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheJulianJES TheJulianJES added the manufacturer This request was made by the device's manufacturer label Oct 10, 2025
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, only a few small things left, then we can merge this.

@TheJulianJES TheJulianJES added the smash This PR is close to be merged soon label Oct 10, 2025
3reality-support and others added 9 commits October 10, 2025 17:55
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
@3reality-support
Copy link
Author

Modified

@3reality-support
Copy link
Author

One more thing, the previous merge was for switch v1 version, and this time we are submitting v2 version with the same mod. Does it have any impact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manufacturer This request was made by the device's manufacturer smash This PR is close to be merged soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants