Skip to content

Commit 2b76aa4

Browse files
🐞 fix: failed to send email
failed to send build notfication mail due to no `from` field #27
1 parent 3d5acb0 commit 2b76aa4

File tree

5 files changed

+13
-2
lines changed

5 files changed

+13
-2
lines changed

docs/history.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
!!! Info
33
`(#{number})` means an issue of this project. You may check details of the issue by visiting https://github.com/zillionare/python-project-wizard/issues/_{number}_
44

5+
## v1.3.1
6+
*[#26](https://github.com/zillionare/python-project-wizard/issues/26) use mike to deploy multiple version of documentation directly, removed github action peaceiris/actions-gh-pages@v3
57
## v1.3
68
* [#23](https://github.com/zillionare/python-project-wizard/issues/23) add email notification upon build success
79
* [#24](https://github.com/zillionare/python-project-wizard/issues/24) config repo secrets by script

docs/tutorial.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,13 @@ This will give you a test report and a lint report. You should see no errors exc
156156
The script looks like the following:
157157
```
158158
# uncomment the following to create repo and push code to github
159+
# gh repo create {{cookiecutter.project_slug}} --public
160+
# git remote add origin git@github.com:{{cookiecutter.github_username}}/{{cookiecutter.project_slug}}.git
161+
# git add .
162+
# pre-commit run --all-files
159163
# git add .
160164
# git commit -m "Initial commit by ppw"
161-
# gh repo create {{cookiecutter.project_slug}} --public -s . --push
165+
# git branch -M main
162166

163167
# Uncomment the following to config github secret used by github workflow.
164168
# gh secret set PERSONAL_TOKEN --body $GH_TOKEN
@@ -167,9 +171,12 @@ This will give you a test report and a lint report. You should see no errors exc
167171

168172
# uncomment the following if you need to setup email notification
169173
# gh secret set BUILD_NOTIFY_MAIL_SERVER --body $BUILD_NOTIFY_MAIL_SERVER
174+
# gh secret set BUILD_NOTIFY_MAIL_PORT --body $BUILD_NOTIFY_MAIL_PORT
170175
# gh secret set BUILD_NOTIFY_MAIL_FROM --body $BUILD_NOTIFY_MAIL_FROM
171176
# gh secret set BUILD_NOTIFY_MAIL_PASSWORD --body $BUILD_NOTIFY_MAIL_PASSWORD
172177
# gh secret set BUILD_NOTIFY_MAIL_RCPT --body $BUILD_NOTIFY_MAIL_RCPT
178+
179+
# git push -u origin main
173180
```
174181
before launch the script, you will need to apply github personal token and set environment variable GH_TOKEN beforehand. And you need install the tool [**gh**](https://cli.github.com/) too.
175182

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[tool]
22
[tool.poetry]
33
name = "ppw"
4-
version = "1.3.0"
4+
version = "1.3.1"
55
description = "A Wizard to create a skeleton python project with up-to-date technology"
66
license = "BSD-3-Clause"
77
authors = ["Aaron Yang <aaron_yang@jieyu.ai>"]

{{cookiecutter.project_slug}}/.github/workflows/dev.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ jobs:
112112
server_port: ${{ secrets.BUILD_NOTIFY_MAIL_PORT }}
113113
username: ${{ secrets.BUILD_NOTIFY_MAIL_FROM }}
114114
password: ${{ secrets.BUILD_NOTIFY_MAIL_PASSWORD }}
115+
from: build-bot
115116
to: ${{ secrets.BUILD_NOTIFY_MAIL_RCPT }}
116117
subject: ${{ env.package_name }}.${{ env.package_version}} build success
117118
body: |

{{cookiecutter.project_slug}}/.github/workflows/release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ jobs:
9393
server_port: ${{ secrets.BUILD_NOTIFY_MAIL_PORT }}
9494
username: ${{ secrets.BUILD_NOTIFY_MAIL_FROM }}
9595
password: ${{ secrets.BUILD_NOTIFY_MAIL_PASSWORD }}
96+
from: build-bot
9697
to: ${{ secrets.BUILD_NOTIFY_MAIL_RCPT }}
9798
subject: ${{ env.package_name }}.${{ env.package_version}} build success
9899
body: |

0 commit comments

Comments
 (0)