Merge pull request #121 from misino/fix/react-16-issue-not-rerendering-handle

mpowaga · web-flow · commit 439de4f4b28b · 2018-02-28T22:53:22.000Z
fix: do not mutate tempArray when creating handles
diff --git a/react-slider.js b/react-slider.js
@@ -758,7 +758,7 @@
         styles[i] = this._buildHandleStyle(offset[i], i);
       }
 
-      var res = this.tempArray;
+      var res = [];
       var renderHandle = this._renderHandle;
       if (React.Children.count(this.props.children) > 0) {
         React.Children.forEach(this.props.children, function (child, i) {

Original file line number	Diff line number	Diff line change
`@@ -758,7 +758,7 @@`
`758`	`758`	`styles[i] = this._buildHandleStyle(offset[i], i);`
`759`	`759`	`}`
`760`	`760`
`761`		`- var res = this.tempArray;`
	`761`	`+ var res = [];`
`762`	`762`	`var renderHandle = this._renderHandle;`
`763`	`763`	`if (React.Children.count(this.props.children) > 0) {`
`764`	`764`	`React.Children.forEach(this.props.children, function (child, i) {`