Modify kill host command to forcibly remove socket #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a configuration where multiple users can host wemux, suppose user foo starts a wemux session and then ends the tmux session without using
wemux stop(say, by closing all tmux windows). In this scenario, the wemux socket will be left as something like...srw-rw-rw- 1 foo foo 0 Sep 6 10:55 wemux-wemux=... and another user, baz, won't be able to successfully run
wemux startbecause the server isn't running and foo owns the socket. If baz has sudo access, baz cansudo chown baz /tmp/wemux/wemuxand then remove it.The wemux script currently responds to both
wemux stopandwemux killby calling thestop_serverfunction. In this PR, we differentiatewemux killby attempting to forcibly change the ownership of the socket (using sudo, as above) before callingstop_server. This is convenient in a multi-tenant compute instance and should help ease some frustration when colleagues forget to cleanly stop the wemux session.