Skip to content

feat: add pre-commit and pre-push git hooks #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 26, 2025
Merged

feat: add pre-commit and pre-push git hooks #22

merged 5 commits into from
Jun 26, 2025

Conversation

uozopio
Copy link
Contributor

@uozopio uozopio commented Jun 26, 2025

Summary

  • Add comprehensive pre-commit and pre-push hooks to catch issues early and save CI minutes
  • Install and configure lint-staged for efficient staged file checking
  • Ensure code quality before it reaches the repository

Changes

Pre-commit Hook

  • Detects merge conflict markers
  • Warns about console.log statements (non-blocking)
  • Warns about large files >5MB (non-blocking)
  • Runs lint-staged for fast checks on staged files only:
    • Biome formatting and linting with auto-fix
    • TypeScript type checking

Pre-push Hook

  • Validates branch naming conventions (matching PR validation rules)
  • Validates commit messages follow conventional commit format
  • Runs full CI suite:
    • pnpm lint - Full linting
    • pnpm typecheck - TypeScript type checking
    • pnpm test - Test suite (with CI=true to avoid watch mode)
    • pnpm build - Build validation

Additional Updates

  • Configure lint-staged in package.json
  • Fix hook to only validate new commits (not entire history)
  • Remove deprecated Husky v9 syntax for v10 compatibility

Test Plan

  • Test merge conflict detection - blocks commits with conflict markers
  • Test console.log warning - shows warning but allows commit
  • Test large file warning - warns about files >5MB
  • Test lint-staged auto-formatting - fixes formatting issues automatically
  • Test TypeScript type checking - catches type errors in staged files
  • Test branch naming validation - blocks invalid branch names
  • Test commit message validation - enforces conventional commit format
  • Test full CI checks run before push - all checks pass

Umutcan ÖNER added 5 commits June 26, 2025 16:25
feat: add VSCode tasks configuration and update package privacy
20f374c 
- Add comprehensive VSCode tasks.json for monorepo development workflows
- Change package.json private field from true to false
feat: add lint-staged configuration for pre-commit hooks
9e8897c
feat: add pre-commit and pre-push git hooks
60c9b0f 
- Pre-commit: checks for merge conflicts, console.logs, large files, and runs lint-staged
- Pre-push: validates branch names, commit messages, and runs full CI checks (lint, typecheck, test, build)
- Helps catch issues early and saves CI minutes
fix: remove deprecated Husky syntax from git hooks
bbc505b 
- Remove shebang and husky.sh sourcing as warned by Husky v9
- These lines will fail in Husky v10
fix: only validate new commits in pre-push hook
cdb5990 
- Check commits since origin/develop for new branches
- Prevents validation errors on existing commits from history
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2025 •
edited
Loading

✅ PR Size Check Passed

This PR changes 620 lines across 5 files.

@uozopio uozopio requested a review from adminzopio June 26, 2025 13:59
@uozopio uozopio merged commit d844c1d into develop Jun 26, 2025
19 checks passed
@uozopio uozopio deleted the feat/git-hooks branch June 26, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adminzopio adminzopio adminzopio approved these changes

Assignees

@uozopio uozopio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uozopio @adminzopio