BeginInclusion Fails in V4

[pnpebeling]

BeginInclusion in the V4 branch fails with a server disconnect error. I can't determine if this is in the Server or .NET component. From the Log and the Z-Stick behavior, inclusion does occur. On a subsequent restart the new node is present.

2025-01-28T15:43:54.234Z DRIVER all queues idle
2025-01-28T15:45:14.553Z CNTRLR Starting inclusion process with strategy Insecure...
2025-01-28T15:45:14.556Z DRIVER one or more queues busy
2025-01-28T15:45:14.559Z SERIAL » 0x0105004ac10a7b (7 bytes)
2025-01-28T15:45:14.561Z DRIVER » [REQ] [AddNodeToNetwork]
node type: Any
high power: true
network wide: true
callback id: 10
2025-01-28T15:45:14.569Z SERIAL « [ACK] (0x06)
2025-01-28T15:45:14.571Z SERIAL « 0x0107004a0a070000bf (9 bytes)
2025-01-28T15:45:14.572Z SERIAL » [ACK] (0x06)
2025-01-28T15:45:14.574Z DRIVER « [REQ] [AddNodeToNetwork]
status: Failed
callback id: 10
2025-01-28T15:45:14.582Z CNTRLR The controller is now ready to add nodes
2025-01-28T15:45:14.583Z DRIVER all queues idle
2025-01-28T15:46:24.318Z DRIVER destroying driver instance...

The call to BeginInclusion throws an Object reference exception.

08:46:04.493, [13], AfwZWaveJSN._OnConnectionLost(): <> System.Exception: Connection to the server was lost. Connection will attempt to be restored: Object reference not set to an instance of an object.

-p

[pnpebeling]

Oops, forgot to include my inclusion options (sigh).

    options.forceSecurity = false;
    options.strategy = Enums.InclusionStrategy.Insecure;
    
    options.userCallbacks = new InclusionUserCallbacks();
    options.userCallbacks.abort = () => {        };
      
    options.userCallbacks.validateDSKAndEnterPIN =
      (String dsk) => {
        return (String.Empty);
      };

    options.userCallbacks.grantSecurityClasses = 
      (InclusionGrant requested) => {
        return (requested);
      };

[marcus-j-davies]

Hi @pnpebeling
I think I know the reason.

it’s another change I missed 🫣

im in the office currently - so will patch it when home soon.

[marcus-j-davies]

OK @pnpebeling

Have patched the inclusion started event (where the error occurred)

See change here : d513236
To support this update on the server:
https://github.com/zwave-js/zwave-js-server/blob/f47d5341aee1e884b5b37438b04e7ec94d4bc040/src/lib/forward.ts#L117

Pull down the changes, and hopefully all good?
Do let me know of other surprises - I can patch them relatively easily 😃

[pnpebeling]

Works. Thx

-p