Skip to content

Allow arguments and options to be passed to child process spawn #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow arguments and options to be passed to child process spawn #11

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82d5fd6
Allow arguments to be passed when spawning child process
IsaacUtah1379 Aug 22, 2024
f301134
Merge pull request #1 from IsaacUtah1379/patch-1
IsaacUtah1379 Aug 22, 2024
83af4bd
Tidy up a bit
IsaacUtah1379 Aug 22, 2024
9fbdbe9
Allow passing options to the call to spawn() that creates the child f…
IsaacUtah1379 Jan 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,11 +166,11 @@ export class PowerJS {
}, 8000);
}

#findOptimalShell(additionalShellNames) {
#findOptimalShell(additionalShellNames, shellArgs, options) {
// Find optimal shell
for (const sname of additionalShellNames) {
try {
this.#child = spawn(sname);
this.#child = spawn(sname, shellArgs, options);
this.#shell = sname;
break;
} catch (e) {
Expand Down Expand Up @@ -245,6 +245,8 @@ export class PowerJS {
autoStart = true,
extensions = [],
dlls = {},
shellArgs = [],
options = {},
} = {}) {
additionalShellNames.push("pwsh", "powershell");

Expand All @@ -255,7 +257,7 @@ export class PowerJS {
}
}

this.#findOptimalShell(additionalShellNames);
this.#findOptimalShell(additionalShellNames, shellArgs, options);
if (this.#child == null) {
throw new Error(
"Cannot find a powershell interpreter! Try installing powershell or adding your one!"
Expand Down